test(e2e): scope Data Quality permissions Playwright helpers to fixture#27238
Merged
shah-harshit merged 2 commits intomainfrom Apr 11, 2026
Merged
test(e2e): scope Data Quality permissions Playwright helpers to fixture#27238shah-harshit merged 2 commits intomainfrom
shah-harshit merged 2 commits intomainfrom
Conversation
Initialize PolicyClass, RolesClass, UserClass, and TableClass inside the Playwright worker fixture instead of module scope to avoid cross-worker shared state (collate#3610). Made-with: Cursor
Contributor
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
shah-harshit
added
UI
Contributor
Jest test CoverageUI tests summary
|
Contributor
🟡 Playwright Results — all passed (23 flaky)✅ 3595 passed · ❌ 0 failed · 🟡 23 flaky · ⏭️ 207 skipped
🟡 23 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
Code Review ✅ ApprovedScopes Data Quality permissions Playwright helpers to fixture for better test isolation. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
|
chirag-madlani
approved these changes
Apr 11, 2026
Contributor
|
Failed to cherry-pick changes to the 1.12.5 branch. |
SaaiAravindhRaja
pushed a commit
to SaaiAravindhRaja/OpenMetadata
that referenced
this pull request
Apr 12, 2026
…a#27238) Initialize PolicyClass, RolesClass, UserClass, and TableClass inside the Playwright worker fixture instead of module scope to avoid cross-worker shared state (collate#3610). Made-with: Cursor
SaaiAravindhRaja
pushed a commit
to SaaiAravindhRaja/OpenMetadata
that referenced
this pull request
Apr 12, 2026
…a#27238) Initialize PolicyClass, RolesClass, UserClass, and TableClass inside the Playwright worker fixture instead of module scope to avoid cross-worker shared state (collate#3610). Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related
https://github.com/open-metadata/openmetadata-collate/issues/3610
Summary
Refactors
DataQualityPermissions.spec.tssoPolicyClass,RolesClass,UserClass, andTableClassinstances are created inside the Playwright worker fixture instead of at module scope. This avoids shared mutable state across parallel workers and improves reliability of the Data Quality permissions E2E suite.Test plan
yarn playwright:runwith filter forDataQualityPermissions.spec.tsMade with Cursor