fix(playwright): Fix flaky announcement reply click in ServiceEntity test#27261
Merged
harsh-vador merged 1 commit intomainfrom Apr 11, 2026
Merged
fix(playwright): Fix flaky announcement reply click in ServiceEntity test#27261harsh-vador merged 1 commit intomainfrom
harsh-vador merged 1 commit intomainfrom
Conversation
Code Review ✅ ApprovedFixes flaky announcement reply click behavior in ServiceEntity test by improving Playwright element interaction reliability. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
Contributor
|
Contributor
🟡 Playwright Results — all passed (21 flaky)✅ 3604 passed · ❌ 0 failed · 🟡 21 flaky · ⏭️ 207 skipped
🟡 21 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
anuj-kumary
approved these changes
Apr 11, 2026
SaaiAravindhRaja
pushed a commit
to SaaiAravindhRaja/OpenMetadata
that referenced
this pull request
Apr 12, 2026
SaaiAravindhRaja
pushed a commit
to SaaiAravindhRaja/OpenMetadata
that referenced
this pull request
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Describe your changes:
Summary
ServiceEntity.spec.tsby clickinggetByTestId('add-reply')directly instead of targeting its child.locator('svg'), which gets detached from the DOM during popover animation in CIRoot Cause
The inner SVG element of the reply button is unstable during popover animations — it can be detached and recreated by React re-renders. In slower CI environments, this race condition triggers "element is not stable" / "element was detached from the DOM" errors. Locally, rendering is fast enough that the click completes before any re-render.
Fix
Aligned the
add-replyclick with the pattern already used byedit-messageanddelete-messagein the same file — click thedata-testidcontainer directly rather than drilling into the SVG child.Screen.Recording.2026-04-11.at.1.43.10.AM.mov
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>