Skip to content

test(e2e): TestCaseResult permissions via UserClass.setCustomRulePolicy#27273

Merged
shah-harshit merged 2 commits intomainfrom
collate-3610-test-case-result-permissions-setCustomRulePolicy
Apr 11, 2026
Merged

test(e2e): TestCaseResult permissions via UserClass.setCustomRulePolicy#27273
shah-harshit merged 2 commits intomainfrom
collate-3610-test-case-result-permissions-setCustomRulePolicy

Conversation

@shah-harshit
Copy link
Copy Markdown
Contributor

Related

https://github.com/open-metadata/openmetadata-collate/issues/3610

Summary

Refactors TestCaseResultPermissions.spec.ts to stop using PolicyClass, RolesClass, and setupUserWithPolicy. Each permission user is created with UserClass.create(apiContext, false) and then receives rules through UserClass.setCustomRulePolicy (policy + role + team), matching the pattern used in DataQualityPermissions.spec.ts.

Test plan

  • yarn eslint on TestCaseResultPermissions.spec.ts
  • yarn playwright:run (or targeted run) for TestCaseResultPermissions.spec.ts

Made with Cursor

Replace PolicyClass/RolesClass/setupUserWithPolicy with UserClass.create +
setCustomRulePolicy for team-based policies (collate#3610).

Made-with: Cursor
@github-actions
Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
63.92% (59755/93475) 43.65% (31229/71542) 46.77% (9394/20085)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 11, 2026

🟡 Playwright Results — all passed (24 flaky)

✅ 3601 passed · ❌ 0 failed · 🟡 24 flaky · ⏭️ 207 skipped

Shard Passed Failed Flaky Skipped
🟡 Shard 1 454 0 3 2
🟡 Shard 2 640 0 3 32
🟡 Shard 3 647 0 3 26
🟡 Shard 4 621 0 6 47
🟡 Shard 5 608 0 1 67
🟡 Shard 6 631 0 8 33
🟡 24 flaky test(s) (passed on retry)
  • Features/CustomizeDetailPage.spec.ts › Data Product - customization should work (shard 1, 1 retry)
  • Features/CustomizeDetailPage.spec.ts › Glossary - customization should work (shard 1, 1 retry)
  • Pages/Roles.spec.ts › Roles page should work properly (shard 1, 1 retry)
  • Features/BulkEditEntity.spec.ts › Glossary (shard 2, 1 retry)
  • Features/ChangeSummaryBadge.spec.ts › Automated badge should appear on entity description with Automated source (shard 2, 1 retry)
  • Features/DataQuality/BundleSuiteBulkOperations.spec.ts › Bulk selection operations (shard 2, 1 retry)
  • Features/NestedColumnsExpandCollapse.spec.ts › should not duplicate rows when expanding and collapsing nested columns with same names (shard 3, 1 retry)
  • Features/Permissions/GlossaryPermissions.spec.ts › Team-based permissions work correctly (shard 3, 1 retry)
  • Flow/ExploreDiscovery.spec.ts › Should display deleted assets when showDeleted is checked and deleted is not present in queryFilter (shard 3, 1 retry)
  • Pages/Customproperties-part2.spec.ts › entityReferenceList shows item count, scrollable list, no expand toggle (shard 4, 1 retry)
  • Pages/DataContracts.spec.ts › Create Data Contract and validate for Container (shard 4, 1 retry)
  • Pages/DataContracts.spec.ts › Create Data Contract and validate for Directory (shard 4, 1 retry)
  • Pages/DataContracts.spec.ts › Contract Status badge should be visible on condition if Contract Tab is present/hidden by Persona (shard 4, 1 retry)
  • Pages/DataProductAndSubdomains.spec.ts › Add expert to data product via UI (shard 4, 1 retry)
  • Pages/Domains.spec.ts › Rename domain with deeply nested subdomains (3+ levels) verifies FQN propagation (shard 4, 1 retry)
  • Pages/ExploreTree.spec.ts › Verify Database and Database Schema available in explore tree (shard 5, 1 retry)
  • Pages/Lineage/DataAssetLineage.spec.ts › verify create lineage for entity - Data Model (shard 6, 1 retry)
  • Pages/Lineage/DataAssetLineage.spec.ts › Column lineage for table -> topic (shard 6, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
  • Pages/Lineage/LineageRightPanel.spec.ts › Verify custom properties tab IS visible for supported type: searchIndex (shard 6, 1 retry)
  • Pages/ProfilerConfigurationPage.spec.ts › Non admin user (shard 6, 1 retry)
  • Pages/Users.spec.ts › Permissions for table details page for Data Consumer (shard 6, 1 retry)
  • Pages/Users.spec.ts › Check permissions for Data Steward (shard 6, 1 retry)
  • VersionPages/EntityVersionPages.spec.ts › Directory (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented Apr 11, 2026

Code Review ✅ Approved

End-to-end test for TestCaseResult permissions via UserClass.setCustomRulePolicy. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud
Copy link
Copy Markdown

@shah-harshit shah-harshit merged commit 6483da5 into main Apr 11, 2026
45 checks passed
@shah-harshit shah-harshit deleted the collate-3610-test-case-result-permissions-setCustomRulePolicy branch April 11, 2026 15:37
SaaiAravindhRaja pushed a commit to SaaiAravindhRaja/OpenMetadata that referenced this pull request Apr 12, 2026
…pen-metadata#27273)

Replace PolicyClass/RolesClass/setupUserWithPolicy with UserClass.create +
setCustomRulePolicy for team-based policies (collate#3610).

Made-with: Cursor
SaaiAravindhRaja pushed a commit to SaaiAravindhRaja/OpenMetadata that referenced this pull request Apr 12, 2026
…pen-metadata#27273)

Replace PolicyClass/RolesClass/setupUserWithPolicy with UserClass.create +
setCustomRulePolicy for team-based policies (collate#3610).

Made-with: Cursor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants