refactor: remove stale TODO comments in UserResource.java Removed outdated TODO comments related to addAuthMechanismToBot method. No functional changes were made.#27297
Open
Sayyed-Arslaan wants to merge 2 commits intoopen-metadata:mainfrom
Conversation
Removes the two stale TODO comments from UserResource.java associated with the addAuthMechanismToBot method. No functional code changes were made. Co-authored-by: Sayyed-Arslaan <166531908+Sayyed-Arslaan@users.noreply.github.com>
… comments in UserResource.java Removed outdated TODO comments related to addAuthMechanismToBot method. No functional changes were made. ### Summary This PR removes stale TODO comments from `UserResource.java` related to the `addAuthMechanismToBot` method. ### Background The existing TODO comments suggested reviewing or removing the `addAuthMechanismToBot` method. However, this method is actively used and is critical for bot authentication workflows. As a result, the TODO comments are no longer relevant and may mislead contributors. ### Changes * Removed outdated TODO comments in `UserResource.java` * No modifications to functional code or logic ### Impact * Improves code readability and cleanliness * Eliminates misleading or outdated developer notes * Ensures better maintainability for future contributors * No impact on runtime behavior or existing features ### Testing * Not required, as this change is purely non-functional (comment cleanup) ### Notes This is a safe refactoring change with zero impact on application behavior.
Contributor
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Code Review ✅ ApprovedRemoves stale TODO comments from UserResource.java with no functional changes. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes #27292
This PR removes stale TODO comments from
UserResource.javarelated to theaddAuthMechanismToBotmethod.These TODO comments were no longer relevant since the method is actively used and critical for bot authentication. Keeping them could cause confusion for contributors.
No functional changes were made.
Type of change:
Checklist:
Fixes #27292: Remove stale TODO comments in UserResource.javaTesting:
Not required, as this change is purely a non-functional cleanup (removal of comments).
Impact: