Skip to content

Fixed the text overflow issues#27426

Open
Rohit0301 wants to merge 3 commits intomainfrom
minor-ui-fixes
Open

Fixed the text overflow issues#27426
Rohit0301 wants to merge 3 commits intomainfrom
minor-ui-fixes

Conversation

@Rohit0301
Copy link
Copy Markdown
Contributor

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Rohit0301 Rohit0301 self-assigned this Apr 16, 2026
@Rohit0301 Rohit0301 added the safe to test Add this label to run secure Github workflows on PRs label Apr 16, 2026
@Rohit0301 Rohit0301 requested a review from a team as a code owner April 16, 2026 08:40
<div className="tw:inline-flex tw:items-center tw:gap-0.5 tw:min-w-0">
<Typography.Text
className={classNames('tw:text-xs', {
className={classNames('tw:text-xs tw:truncate tw:max-w-32', {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Edge Case: Hardcoded tw:max-w-32 may truncate breadcrumbs too aggressively

The breadcrumb text is truncated at tw:max-w-32 (128px) for all items. For deeply nested columns with long names, every breadcrumb segment will be truncated, making it difficult for users to distinguish between similarly-named segments. Consider using a responsive or relative max-width, or allowing the last breadcrumb item (the current column) to have a larger max-width since it's the most relevant.

Suggested fix:

Apply a wider max-width to the last breadcrumb item:
className={classNames('tw:text-xs tw:truncate', {
  'tw:max-w-48 tw:cursor-default tw:font-medium tw:text-gray-700': isLastItem,
  'tw:max-w-32 tw:cursor-pointer tw:font-normal tw:text-gray-400 hover:tw:underline': !isLastItem,
})}

Was this helpful? React with 👍 / 👎 | Reply gitar fix to apply this suggestion

@github-actions
Copy link
Copy Markdown
Contributor

❌ Lint Check Failed — ESLint + Prettier + Organise Imports (src)

The following files have style issues that need to be fixed:
src/components/Database/ColumnDetailPanel/ColumnDetailPanel.component.tsx src/components/Entity/EntityLineage/CustomControls.component.tsx src/components/common/EntityTitleSection/EntityTitleSection.tsx src/pages/TagsPage/ClassificationFormDrawer.tsx src/pages/TagsPage/TagFormDrawer.tsx src/pages/TagsPage/TagsPage.tsx

Fix locally (fast — only for changed files in the branch):

make ui-checkstyle-src-changed

Or to fix all files:

make ui-checkstyle-src

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 16, 2026

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
63.73% (59601/93521) 43.65% (31364/71853) 46.73% (9425/20165)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 16, 2026

🟡 Playwright Results — all passed (24 flaky)

✅ 3657 passed · ❌ 0 failed · 🟡 24 flaky · ⏭️ 89 skipped

Shard Passed Failed Flaky Skipped
🟡 Shard 1 476 0 4 4
🟡 Shard 2 649 0 2 7
🟡 Shard 3 651 0 5 1
🟡 Shard 4 628 0 6 27
🟡 Shard 5 609 0 2 42
🟡 Shard 6 644 0 5 8
🟡 24 flaky test(s) (passed on retry)
  • Features/DataAssetRulesDisabled.spec.ts › Verify the Chart entity item action after rules disabled (shard 1, 1 retry)
  • Features/CustomizeDetailPage.spec.ts › Data Product - customization should work (shard 1, 1 retry)
  • Features/CustomizeDetailPage.spec.ts › Glossary Term - customization should work (shard 1, 1 retry)
  • Pages/UserCreationWithPersona.spec.ts › Create user with persona and verify on profile (shard 1, 1 retry)
  • Features/BulkEditEntity.spec.ts › Glossary (shard 2, 1 retry)
  • Features/ChangeSummaryBadge.spec.ts › Automated badge should appear on entity description with Automated source (shard 2, 1 retry)
  • Features/RestoreEntityInheritedFields.spec.ts › Validate restore with Inherited domain and data products assigned (shard 3, 2 retries)
  • Features/RestoreEntityInheritedFields.spec.ts › Validate restore with Inherited domain and data products assigned (shard 3, 1 retry)
  • Features/RestoreEntityInheritedFields.spec.ts › Validate restore with Inherited domain and data products assigned (shard 3, 2 retries)
  • Features/RestoreEntityInheritedFields.spec.ts › Validate restore with Inherited domain and data products assigned (shard 3, 2 retries)
  • Features/RTL.spec.ts › Verify Following widget functionality (shard 3, 1 retry)
  • Pages/Customproperties-part2.spec.ts › entityReferenceList shows item count, scrollable list, no expand toggle (shard 4, 1 retry)
  • Pages/DataContracts.spec.ts › Create Data Contract and validate for Spreadsheet (shard 4, 1 retry)
  • Pages/DataContracts.spec.ts › Create Data Contract and validate for Database (shard 4, 1 retry)
  • Pages/DataProductAndSubdomains.spec.ts › Add expert to data product via UI (shard 4, 1 retry)
  • Pages/Domains.spec.ts › Rename domain with owners and experts preserves assignments (shard 4, 1 retry)
  • Pages/Entity.spec.ts › Follow & Un-follow entity (shard 4, 1 retry)
  • Pages/EntityDataSteward.spec.ts › User as Owner Add, Update and Remove (shard 5, 1 retry)
  • Pages/Glossary.spec.ts › Add and Remove Assets (shard 5, 1 retry)
  • Pages/HyperlinkCustomProperty.spec.ts › should display URL when no display text is provided (shard 6, 1 retry)
  • Pages/Lineage/DataAssetLineage.spec.ts › Column lineage for searchIndex -> table (shard 6, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
  • Pages/UserDetails.spec.ts › Create team with domain and verify visibility of inherited domain in user profile after team removal (shard 6, 1 retry)
  • Pages/Users.spec.ts › Permissions for table details page for Data Consumer (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@gitar-bot
Copy link
Copy Markdown

gitar-bot bot commented Apr 16, 2026

Code Review 👍 Approved with suggestions 1 resolved / 2 findings

Migration of inline styles to CSS classes resolves the styling inconsistency. Consider relaxing the hardcoded breadcrumb width constraint to prevent aggressive truncation.

💡 Edge Case: Hardcoded tw:max-w-32 may truncate breadcrumbs too aggressively

📄 openmetadata-ui/src/main/resources/ui/src/components/Database/ColumnDetailPanel/ColumnDetailPanel.component.tsx:817

The breadcrumb text is truncated at tw:max-w-32 (128px) for all items. For deeply nested columns with long names, every breadcrumb segment will be truncated, making it difficult for users to distinguish between similarly-named segments. Consider using a responsive or relative max-width, or allowing the last breadcrumb item (the current column) to have a larger max-width since it's the most relevant.

Suggested fix
Apply a wider max-width to the last breadcrumb item:
className={classNames('tw:text-xs tw:truncate', {
  'tw:max-w-48 tw:cursor-default tw:font-medium tw:text-gray-700': isLastItem,
  'tw:max-w-32 tw:cursor-pointer tw:font-normal tw:text-gray-400 hover:tw:underline': !isLastItem,
})}
✅ 1 resolved
Quality: Inline style on line 845 should be in CSS class

📄 openmetadata-ui/src/main/resources/ui/src/components/Database/ColumnDetailPanel/ColumnDetailPanel.component.tsx:845
The style={{ flex: 1 }} inline style on line 845 is inconsistent with the rest of the approach in this PR, which defines layout properties in the ColumnDetailPanel.less file via CSS classes like title-row and title-text-column. This inline style should be incorporated into the title-row class or a dedicated class to keep styling consistent and maintainable.

🤖 Prompt for agents
Code Review: Migration of inline styles to CSS classes resolves the styling inconsistency. Consider relaxing the hardcoded breadcrumb width constraint to prevent aggressive truncation.

1. 💡 Edge Case: Hardcoded tw:max-w-32 may truncate breadcrumbs too aggressively
   Files: openmetadata-ui/src/main/resources/ui/src/components/Database/ColumnDetailPanel/ColumnDetailPanel.component.tsx:817

   The breadcrumb text is truncated at `tw:max-w-32` (128px) for all items. For deeply nested columns with long names, every breadcrumb segment will be truncated, making it difficult for users to distinguish between similarly-named segments. Consider using a responsive or relative max-width, or allowing the last breadcrumb item (the current column) to have a larger max-width since it's the most relevant.

   Suggested fix:
   Apply a wider max-width to the last breadcrumb item:
   className={classNames('tw:text-xs tw:truncate', {
     'tw:max-w-48 tw:cursor-default tw:font-medium tw:text-gray-700': isLastItem,
     'tw:max-w-32 tw:cursor-pointer tw:font-normal tw:text-gray-400 hover:tw:underline': !isLastItem,
   })}

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant