Skip to content

Fix aut flakiness restore entity inherited fields.spec.ts#27534

Open
shrabantipaul-collate wants to merge 12 commits intomainfrom
fix-aut-flakiness-RestoreEntityInheritedFields.spec.ts
Open

Fix aut flakiness restore entity inherited fields.spec.ts#27534
shrabantipaul-collate wants to merge 12 commits intomainfrom
fix-aut-flakiness-RestoreEntityInheritedFields.spec.ts

Conversation

@shrabantipaul-collate
Copy link
Copy Markdown
Contributor

@shrabantipaul-collate shrabantipaul-collate commented Apr 20, 2026

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Summary by Gitar

  • Test Stability:
    • Increased timeout and adjusted intervals for inherited domain verification in RestoreEntityInheritedFields.spec.ts to reduce flakiness.
  • Cleanup:
    • Removed unused DATA_ASSET_RULES import in RestoreEntityInheritedFields.spec.ts.
    • Applied minor formatting changes to imports in DataAssetRulesEnabled.spec.ts.

This will update automatically on new commits.

@shrabantipaul-collate shrabantipaul-collate added the safe to test Add this label to run secure Github workflows on PRs label Apr 20, 2026
@shrabantipaul-collate shrabantipaul-collate requested a review from a team as a code owner April 20, 2026 06:07
@github-actions
Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
63.31% (59282/93635) 43.61% (31448/72106) 46.49% (9435/20293)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 20, 2026

🟡 Playwright Results — all passed (16 flaky)

✅ 3671 passed · ❌ 0 failed · 🟡 16 flaky · ⏭️ 89 skipped

Shard Passed Failed Flaky Skipped
🟡 Shard 1 479 0 2 4
🟡 Shard 2 649 0 4 7
🟡 Shard 3 657 0 2 1
🟡 Shard 4 633 0 1 27
🟡 Shard 5 610 0 1 42
🟡 Shard 6 643 0 6 8
🟡 16 flaky test(s) (passed on retry)
  • Pages/Customproperties-part1.spec.ts › Integer (shard 1, 1 retry)
  • Pages/UserCreationWithPersona.spec.ts › Create user with persona and verify on profile (shard 1, 1 retry)
  • Features/BulkEditEntity.spec.ts › Glossary (shard 2, 1 retry)
  • Features/BulkImport.spec.ts › Database Schema (shard 2, 1 retry)
  • Features/Glossary/GlossaryHierarchy.spec.ts › should cancel move operation (shard 2, 1 retry)
  • Features/Glossary/GlossaryWorkflow.spec.ts › should display correct status badge color and icon (shard 2, 2 retries)
  • Features/RestoreEntityInheritedFields.spec.ts › Validate restore with Inherited domain and data products assigned (shard 3, 1 retry)
  • Flow/PersonaDeletionUserProfile.spec.ts › User profile loads correctly before and after persona deletion (shard 3, 1 retry)
  • Pages/Customproperties-part2.spec.ts › entityReferenceList shows item count, scrollable list, no expand toggle (shard 4, 1 retry)
  • Pages/Glossary.spec.ts › Add and Remove Assets (shard 5, 1 retry)
  • Pages/Lineage/DataAssetLineage.spec.ts › verify create lineage for entity - Search Index (shard 6, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
  • Pages/Lineage/LineageRightPanel.spec.ts › Verify custom properties tab IS visible for supported type: searchIndex (shard 6, 1 retry)
  • Pages/Users.spec.ts › Permissions for table details page for Data Consumer (shard 6, 1 retry)
  • Pages/Users.spec.ts › Check permissions for Data Steward (shard 6, 1 retry)
  • VersionPages/EntityVersionPages.spec.ts › Directory (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 20, 2026

❌ UI Checkstyle Failed

❌ Playwright — ESLint + Prettier + Organise Imports

One or more Playwright test files have linting or formatting issues.

Affected files
  • openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/DataAssetRulesEnabled.spec.ts

Fix locally (fast — only checks files changed in this branch):

make ui-checkstyle-changed

@gitar-bot
Copy link
Copy Markdown

gitar-bot bot commented Apr 20, 2026

Code Review ✅ Approved

Restores stability to the entity inherited fields test suite by addressing timing-related flakiness. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant