feat(ui): rename old-sidebar Marketplace section to 'Data Marketplace' / 'Overview'#27539
feat(ui): rename old-sidebar Marketplace section to 'Data Marketplace' / 'Overview'#27539
Conversation
…" / "Overview" Disambiguate the old left sidebar: the "Marketplace" parent and its first child both rendered the same "Marketplace" label. Rename the parent to "Data Marketplace" (new i18n key label.data-marketplace-section) and the child to "Overview" (reusing label.overview). Other callers of label.data-marketplace (breadcrumbs, new sidebar, page titles, persona setup) are unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
There was a problem hiding this comment.
Pull request overview
Updates the old left sidebar’s Marketplace section labels to avoid a duplicated “Marketplace” parent/child naming by introducing a dedicated section label and renaming the first child to “Overview”.
Changes:
- Update old sidebar section title to use new i18n key
label.data-marketplace-section. - Rename the first child item under that section to
label.overview. - Add/sync the new
"data-marketplace-section"label across all locales.
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| openmetadata-ui/src/main/resources/ui/src/constants/LeftSidebar.constants.ts | Uses label.data-marketplace-section for the parent and label.overview for the first child to remove the duplicated label. |
| openmetadata-ui/src/main/resources/ui/src/locale/languages/en-us.json | Adds "data-marketplace-section": "Data Marketplace" under label. |
| openmetadata-ui/src/main/resources/ui/src/locale/languages/ar-sa.json | Syncs the new data-marketplace-section label key. |
| openmetadata-ui/src/main/resources/ui/src/locale/languages/de-de.json | Syncs the new data-marketplace-section label key. |
| openmetadata-ui/src/main/resources/ui/src/locale/languages/es-es.json | Syncs the new data-marketplace-section label key. |
| openmetadata-ui/src/main/resources/ui/src/locale/languages/fr-fr.json | Syncs the new data-marketplace-section label key. |
| openmetadata-ui/src/main/resources/ui/src/locale/languages/gl-es.json | Syncs the new data-marketplace-section label key. |
| openmetadata-ui/src/main/resources/ui/src/locale/languages/he-he.json | Syncs the new data-marketplace-section label key. |
| openmetadata-ui/src/main/resources/ui/src/locale/languages/ja-jp.json | Syncs the new data-marketplace-section label key. |
| openmetadata-ui/src/main/resources/ui/src/locale/languages/ko-kr.json | Syncs the new data-marketplace-section label key. |
| openmetadata-ui/src/main/resources/ui/src/locale/languages/mr-in.json | Syncs the new data-marketplace-section label key. |
| openmetadata-ui/src/main/resources/ui/src/locale/languages/nl-nl.json | Syncs the new data-marketplace-section label key. |
| openmetadata-ui/src/main/resources/ui/src/locale/languages/pr-pr.json | Syncs the new data-marketplace-section label key. |
| openmetadata-ui/src/main/resources/ui/src/locale/languages/pt-br.json | Syncs the new data-marketplace-section label key. |
| openmetadata-ui/src/main/resources/ui/src/locale/languages/pt-pt.json | Syncs the new data-marketplace-section label key. |
| openmetadata-ui/src/main/resources/ui/src/locale/languages/ru-ru.json | Syncs the new data-marketplace-section label key. |
| openmetadata-ui/src/main/resources/ui/src/locale/languages/th-th.json | Syncs the new data-marketplace-section label key. |
| openmetadata-ui/src/main/resources/ui/src/locale/languages/tr-tr.json | Syncs the new data-marketplace-section label key. |
| openmetadata-ui/src/main/resources/ui/src/locale/languages/zh-cn.json | Syncs the new data-marketplace-section label key. |
| openmetadata-ui/src/main/resources/ui/src/locale/languages/zh-tw.json | Syncs the new data-marketplace-section label key. |
Replace the Building02-based MarketplaceIcon with a custom SVG (ic-data-marketplace.svg) so the Data Marketplace section has a distinct visual identity in the old left sidebar. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Code Review ✅ ApprovedRenames the Marketplace sidebar section to 'Data Marketplace' and 'Overview' for improved clarity. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
|
🟡 Playwright Results — all passed (20 flaky)✅ 3667 passed · ❌ 0 failed · 🟡 20 flaky · ⏭️ 89 skipped
🟡 20 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |



Summary
label.data-marketplace. This duplication was confusing.label.data-marketplace-section, and the first child to "Overview" by reusing the existinglabel.overviewkey.label.data-marketplace(Domain/DataProduct breadcrumbs, the new sidebar, Marketplace page titles, persona customization labels) continue to resolve to "Marketplace" and are untouched.Changes
openmetadata-ui/.../constants/LeftSidebar.constants.ts— swap the two duplicated titles.openmetadata-ui/.../locale/languages/en-us.json— add"data-marketplace-section": "Data Marketplace".yarn i18n.Test plan
yarn test—LeftSidebar.test.tsx,LeftSidebarItem.test.tsx,LeftSidebarClassBase.test.ts,useSidebarItems.test.ts,PersonaUtils.test.tsall green (38/38).yarn i18nis a no-op on re-run (keys are in sync across all 19 locales).🤖 Generated with Claude Code
Summary by Gitar
ic-data-marketplace.svgas a new icon asset for the sidebar.Building02icon with the customMarketplaceIconinLeftSidebar.constants.ts.This will update automatically on new commits.