Skip to content

feat(ui): rename old-sidebar Marketplace section to 'Data Marketplace' / 'Overview'#27539

Open
siddhant1 wants to merge 4 commits intomainfrom
rename-sidebar-marketplace-section
Open

feat(ui): rename old-sidebar Marketplace section to 'Data Marketplace' / 'Overview'#27539
siddhant1 wants to merge 4 commits intomainfrom
rename-sidebar-marketplace-section

Conversation

@siddhant1
Copy link
Copy Markdown
Member

@siddhant1 siddhant1 commented Apr 20, 2026

Summary

  • The old left sidebar rendered a section whose parent label and its first child label both read "Marketplace", because both reused the same i18n key label.data-marketplace. This duplication was confusing.
  • Rename the parent to "Data Marketplace" via a new i18n key label.data-marketplace-section, and the first child to "Overview" by reusing the existing label.overview key.
  • Scope is intentionally surgical: other callers of label.data-marketplace (Domain/DataProduct breadcrumbs, the new sidebar, Marketplace page titles, persona customization labels) continue to resolve to "Marketplace" and are untouched.

Changes

  • openmetadata-ui/.../constants/LeftSidebar.constants.ts — swap the two duplicated titles.
  • openmetadata-ui/.../locale/languages/en-us.json — add "data-marketplace-section": "Data Marketplace".
  • 18 other locale files — auto-synced via yarn i18n.

Test plan

  • yarn testLeftSidebar.test.tsx, LeftSidebarItem.test.tsx, LeftSidebarClassBase.test.ts, useSidebarItems.test.ts, PersonaUtils.test.ts all green (38/38).
  • yarn i18n is a no-op on re-run (keys are in sync across all 19 locales).
  • Manual: open the old sidebar and confirm the section header reads "Data Marketplace" and its first child reads "Overview".
  • Manual: confirm breadcrumbs on Domain and Data Product pages still read "Marketplace" (unchanged).
  • Manual: confirm the new sidebar (for personas on the new layout) still shows "Marketplace" at that nav item (unchanged).

🤖 Generated with Claude Code


Summary by Gitar

  • UI Improvements:
    • Added ic-data-marketplace.svg as a new icon asset for the sidebar.
    • Replaced the generic Building02 icon with the custom MarketplaceIcon in LeftSidebar.constants.ts.

This will update automatically on new commits.

…" / "Overview"

Disambiguate the old left sidebar: the "Marketplace" parent and its first
child both rendered the same "Marketplace" label. Rename the parent to
"Data Marketplace" (new i18n key label.data-marketplace-section) and the
child to "Overview" (reusing label.overview). Other callers of
label.data-marketplace (breadcrumbs, new sidebar, page titles, persona
setup) are unchanged.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings April 20, 2026 06:59
@siddhant1 siddhant1 requested a review from a team as a code owner April 20, 2026 06:59
@github-actions
Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the old left sidebar’s Marketplace section labels to avoid a duplicated “Marketplace” parent/child naming by introducing a dedicated section label and renaming the first child to “Overview”.

Changes:

  • Update old sidebar section title to use new i18n key label.data-marketplace-section.
  • Rename the first child item under that section to label.overview.
  • Add/sync the new "data-marketplace-section" label across all locales.

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.

Show a summary per file
File Description
openmetadata-ui/src/main/resources/ui/src/constants/LeftSidebar.constants.ts Uses label.data-marketplace-section for the parent and label.overview for the first child to remove the duplicated label.
openmetadata-ui/src/main/resources/ui/src/locale/languages/en-us.json Adds "data-marketplace-section": "Data Marketplace" under label.
openmetadata-ui/src/main/resources/ui/src/locale/languages/ar-sa.json Syncs the new data-marketplace-section label key.
openmetadata-ui/src/main/resources/ui/src/locale/languages/de-de.json Syncs the new data-marketplace-section label key.
openmetadata-ui/src/main/resources/ui/src/locale/languages/es-es.json Syncs the new data-marketplace-section label key.
openmetadata-ui/src/main/resources/ui/src/locale/languages/fr-fr.json Syncs the new data-marketplace-section label key.
openmetadata-ui/src/main/resources/ui/src/locale/languages/gl-es.json Syncs the new data-marketplace-section label key.
openmetadata-ui/src/main/resources/ui/src/locale/languages/he-he.json Syncs the new data-marketplace-section label key.
openmetadata-ui/src/main/resources/ui/src/locale/languages/ja-jp.json Syncs the new data-marketplace-section label key.
openmetadata-ui/src/main/resources/ui/src/locale/languages/ko-kr.json Syncs the new data-marketplace-section label key.
openmetadata-ui/src/main/resources/ui/src/locale/languages/mr-in.json Syncs the new data-marketplace-section label key.
openmetadata-ui/src/main/resources/ui/src/locale/languages/nl-nl.json Syncs the new data-marketplace-section label key.
openmetadata-ui/src/main/resources/ui/src/locale/languages/pr-pr.json Syncs the new data-marketplace-section label key.
openmetadata-ui/src/main/resources/ui/src/locale/languages/pt-br.json Syncs the new data-marketplace-section label key.
openmetadata-ui/src/main/resources/ui/src/locale/languages/pt-pt.json Syncs the new data-marketplace-section label key.
openmetadata-ui/src/main/resources/ui/src/locale/languages/ru-ru.json Syncs the new data-marketplace-section label key.
openmetadata-ui/src/main/resources/ui/src/locale/languages/th-th.json Syncs the new data-marketplace-section label key.
openmetadata-ui/src/main/resources/ui/src/locale/languages/tr-tr.json Syncs the new data-marketplace-section label key.
openmetadata-ui/src/main/resources/ui/src/locale/languages/zh-cn.json Syncs the new data-marketplace-section label key.
openmetadata-ui/src/main/resources/ui/src/locale/languages/zh-tw.json Syncs the new data-marketplace-section label key.

@siddhant1 siddhant1 added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Apr 20, 2026
Replace the Building02-based MarketplaceIcon with a custom SVG
(ic-data-marketplace.svg) so the Data Marketplace section has a
distinct visual identity in the old left sidebar.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings April 20, 2026 07:28
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 21 changed files in this pull request and generated 1 comment.

@github-actions
Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
63.31% (59281/93635) 43.61% (31448/72106) 46.48% (9434/20293)

@gitar-bot
Copy link
Copy Markdown

gitar-bot bot commented Apr 20, 2026

Code Review ✅ Approved

Renames the Marketplace sidebar section to 'Data Marketplace' and 'Overview' for improved clarity. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

🟡 Playwright Results — all passed (20 flaky)

✅ 3667 passed · ❌ 0 failed · 🟡 20 flaky · ⏭️ 89 skipped

Shard Passed Failed Flaky Skipped
🟡 Shard 1 480 0 1 4
🟡 Shard 2 650 0 3 7
🟡 Shard 3 655 0 4 1
🟡 Shard 4 631 0 3 27
✅ Shard 5 611 0 0 42
🟡 Shard 6 640 0 9 8
🟡 20 flaky test(s) (passed on retry)
  • Pages/UserCreationWithPersona.spec.ts › Create user with persona and verify on profile (shard 1, 1 retry)
  • Features/BulkEditEntity.spec.ts › Database service (shard 2, 1 retry)
  • Features/BulkEditEntity.spec.ts › Glossary (shard 2, 1 retry)
  • Features/DataProductRename.spec.ts › should rename data product and verify assets are still associated (shard 2, 1 retry)
  • Features/RestoreEntityInheritedFields.spec.ts › Validate restore with Inherited domain and data products assigned (shard 3, 1 retry)
  • Features/RestoreEntityInheritedFields.spec.ts › Validate restore with Inherited domain and data products assigned (shard 3, 1 retry)
  • Features/RestoreEntityInheritedFields.spec.ts › Validate restore with Inherited domain and data products assigned (shard 3, 1 retry)
  • Features/RTL.spec.ts › Verify Following widget functionality (shard 3, 1 retry)
  • Pages/Customproperties-part2.spec.ts › Entity Reference List (shard 4, 1 retry)
  • Pages/Customproperties-part2.spec.ts › entityReferenceList shows item count, scrollable list, no expand toggle (shard 4, 1 retry)
  • Pages/DataContracts.spec.ts › Create Data Contract and validate for Chart (shard 4, 1 retry)
  • Pages/HyperlinkCustomProperty.spec.ts › should display URL when no display text is provided (shard 6, 1 retry)
  • Pages/Lineage/DataAssetLineage.spec.ts › verify create lineage for entity - Container (shard 6, 1 retry)
  • Pages/Lineage/DataAssetLineage.spec.ts › verify create lineage for entity - Directory (shard 6, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
  • Pages/Lineage/LineageRightPanel.spec.ts › Verify custom properties tab IS visible for supported type: searchIndex (shard 6, 1 retry)
  • Pages/Lineage/PlatformLineage.spec.ts › Verify domain platform view (shard 6, 1 retry)
  • Pages/Users.spec.ts › Permissions for table details page for Data Consumer (shard 6, 1 retry)
  • Pages/Users.spec.ts › Check permissions for Data Steward (shard 6, 1 retry)
  • VersionPages/EntityVersionPages.spec.ts › Directory (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants