Skip to content

fix(e2e): fix flaky DataContracts owner assignment crashing on undefined displayName#27592

Merged
shrabantipaul-collate merged 11 commits intomainfrom
fix-owner-field-dataContracts-specs
Apr 22, 2026
Merged

fix(e2e): fix flaky DataContracts owner assignment crashing on undefined displayName#27592
shrabantipaul-collate merged 11 commits intomainfrom
fix-owner-field-dataContracts-specs

Conversation

@shrabantipaul-collate
Copy link
Copy Markdown
Contributor

Describe your changes:

Issue

user.responseData.displayName is undefined at runtime (signup API doesn't auto-populate it), causing waitForResponse to wait for q=undefined — a URL that never fires. The test times out, the page closes, and Playwright throws "Target page, context or browser has been closed".

Fix

Use user.getUserDisplayName() which already falls back to responseData.name when displayName is absent.
Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@shrabantipaul-collate shrabantipaul-collate requested a review from a team as a code owner April 21, 2026 13:24
@shrabantipaul-collate shrabantipaul-collate added the safe to test Add this label to run secure Github workflows on PRs label Apr 21, 2026
@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented Apr 21, 2026

Code Review ✅ Approved

Adds a null-coalescing check for displayName when assigning DataContracts owners, resolving the root cause of flaky E2E test crashes. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@github-actions
Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 61%
61.98% (60411/97454) 42.02% (31688/75403) 45.02% (9506/21111)

@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

🟡 Playwright Results — all passed (9 flaky)

✅ 3702 passed · ❌ 0 failed · 🟡 9 flaky · ⏭️ 89 skipped

Shard Passed Failed Flaky Skipped
✅ Shard 1 481 0 0 4
🟡 Shard 2 655 0 1 7
✅ Shard 3 666 0 0 1
🟡 Shard 4 646 0 2 27
🟡 Shard 5 610 0 1 42
🟡 Shard 6 644 0 5 8
🟡 9 flaky test(s) (passed on retry)
  • Features/BulkEditEntity.spec.ts › Glossary (shard 2, 1 retry)
  • Pages/Customproperties-part2.spec.ts › entityReferenceList shows item count, scrollable list, no expand toggle (shard 4, 1 retry)
  • Pages/DataInsightReportApplication.spec.ts › Uninstall application (shard 4, 1 retry)
  • Pages/Glossary.spec.ts › Add and Remove Assets (shard 5, 1 retry)
  • Features/AutoPilot.spec.ts › Agents created by AutoPilot should be deleted (shard 6, 1 retry)
  • Pages/HyperlinkCustomProperty.spec.ts › should display URL when no display text is provided (shard 6, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
  • Pages/Lineage/LineageRightPanel.spec.ts › Verify custom properties tab IS visible for supported type: searchIndex (shard 6, 1 retry)
  • Pages/Users.spec.ts › Permissions for table details page for Data Consumer (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@shrabantipaul-collate shrabantipaul-collate merged commit a1f5de7 into main Apr 22, 2026
59 of 79 checks passed
@shrabantipaul-collate shrabantipaul-collate deleted the fix-owner-field-dataContracts-specs branch April 22, 2026 05:04
shrabantipaul-collate added a commit that referenced this pull request Apr 22, 2026
…ned displayName (#27592)

* increase data contracts test timeout

* fix contract form with owner field

---------

Co-authored-by: Shrabanti Paul <shrabantipaul@Shrabantis-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants