fix(e2e): fix flaky DataContracts owner assignment crashing on undefined displayName#27592
Merged
shrabantipaul-collate merged 11 commits intomainfrom Apr 22, 2026
Merged
Conversation
added 11 commits
April 15, 2026 12:39
Code Review ✅ ApprovedAdds a null-coalescing check for displayName when assigning DataContracts owners, resolving the root cause of flaky E2E test crashes. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
Rohit0301
approved these changes
Apr 21, 2026
Contributor
|
Contributor
🟡 Playwright Results — all passed (9 flaky)✅ 3702 passed · ❌ 0 failed · 🟡 9 flaky · ⏭️ 89 skipped
🟡 9 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
shrabantipaul-collate
added a commit
that referenced
this pull request
Apr 22, 2026
…ned displayName (#27592) * increase data contracts test timeout * fix contract form with owner field --------- Co-authored-by: Shrabanti Paul <shrabantipaul@Shrabantis-MacBook-Pro.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Describe your changes:
Issue
user.responseData.displayName is undefined at runtime (signup API doesn't auto-populate it), causing waitForResponse to wait for q=undefined — a URL that never fires. The test times out, the page closes, and Playwright throws "Target page, context or browser has been closed".
Fix
Use user.getUserDisplayName() which already falls back to responseData.name when displayName is absent.
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>