Skip to content

Feat:Add pagination support for execution history and edge deletion#27612

Merged
anuj-kumary merged 7 commits intomainfrom
issue-#3391
Apr 23, 2026
Merged

Feat:Add pagination support for execution history and edge deletion#27612
anuj-kumary merged 7 commits intomainfrom
issue-#3391

Conversation

@anuj-kumary
Copy link
Copy Markdown
Member

@anuj-kumary anuj-kumary commented Apr 22, 2026

Describe your changes:

Added pagination support for workflow execution history and edge deletion for collate side.

Screen.Recording.2026-04-22.at.12.23.33.PM.mov

Will introduced test on collate side

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Summary by Gitar

  • Test infrastructure:
    • Wrapped existing Playwright tests in WorkflowOssRestrictions.spec.ts with a conditional check for PLAYWRIGHT_IS_OSS environment variable.

This will update automatically on new commits.

@anuj-kumary anuj-kumary self-assigned this Apr 22, 2026
@anuj-kumary anuj-kumary requested a review from a team as a code owner April 22, 2026 07:04
@github-actions
Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@anuj-kumary anuj-kumary added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Apr 22, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 22, 2026

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 61%
62.01% (60371/97352) 42% (31636/75306) 45% (9502/21111)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 22, 2026

🟡 Playwright Results — all passed (15 flaky)

✅ 3696 passed · ❌ 0 failed · 🟡 15 flaky · ⏭️ 89 skipped

Shard Passed Failed Flaky Skipped
🟡 Shard 1 478 0 3 4
🟡 Shard 2 653 0 3 7
🟡 Shard 3 665 0 1 1
🟡 Shard 4 647 0 1 27
🟡 Shard 5 609 0 2 42
🟡 Shard 6 644 0 5 8
🟡 15 flaky test(s) (passed on retry)
  • Pages/AuditLogs.spec.ts › should apply both User and EntityType filters simultaneously (shard 1, 1 retry)
  • Pages/Customproperties-part1.spec.ts › no duplicate card after update (shard 1, 1 retry)
  • Pages/UserCreationWithPersona.spec.ts › Create user with persona and verify on profile (shard 1, 1 retry)
  • Features/BulkEditEntity.spec.ts › Glossary (shard 2, 1 retry)
  • Features/DataQuality/TestCaseImportExportE2eFlow.spec.ts › Admin: Complete export-import-validate flow (shard 2, 1 retry)
  • Features/DataQuality/TestCaseResultPermissions.spec.ts › User with only VIEW cannot PATCH results (shard 2, 1 retry)
  • Flow/PersonaDeletionUserProfile.spec.ts › User profile loads correctly before and after persona deletion (shard 3, 1 retry)
  • Pages/Customproperties-part2.spec.ts › entityReferenceList shows item count, scrollable list, no expand toggle (shard 4, 1 retry)
  • Pages/EntityDataConsumer.spec.ts › Tier Add, Update and Remove (shard 5, 1 retry)
  • Pages/ExplorePageRightPanel.spec.ts › Should verify deleted user not visible in owner selection for table (shard 5, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
  • Pages/Lineage/LineageRightPanel.spec.ts › Verify custom properties tab IS visible for supported type: searchIndex (shard 6, 1 retry)
  • Pages/Users.spec.ts › Permissions for table details page for Data Consumer (shard 6, 1 retry)
  • Pages/Users.spec.ts › Check permissions for Data Steward (shard 6, 1 retry)
  • Pages/Users.spec.ts › Should navigate to user profile from feed card avatar click (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented Apr 22, 2026

Code Review ✅ Approved 2 resolved / 2 findings

Pagination support for execution history and edge deletion is now implemented. Conditional rendering logic for the pagination bar and dependency array issues have been resolved.

✅ 2 resolved
Edge Case: Pagination bar renders needlessly for single-page results

📄 openmetadata-ui/src/main/resources/ui/src/components/WorkflowDefinitions/WorkflowBuilder/WorkflowExecutionHistory.tsx:189
The condition paging.total > 0 at line 189 shows the NextPrevious component even when all results fit on a single page (no before/after cursors). This renders a "Page 1 of 1" bar with both buttons disabled, which adds visual noise without providing value.

Consider gating on whether there are actually multiple pages:

Quality: useEffect missing fetchExecutionHistory in dependency array

📄 openmetadata-ui/src/main/resources/ui/src/components/WorkflowDefinitions/WorkflowBuilder/WorkflowExecutionHistory.tsx:156-159
The useEffect at line 156 calls fetchExecutionHistory() but omits it from the dependency array [workflowFqn, pageSize]. This will trigger an react-hooks/exhaustive-deps lint warning. Currently safe because the callback's own dependencies (workflowFqn, pageSize) are already listed, but it's fragile — if fetchExecutionHistory gains additional dependencies in the future, the effect won't re-run as expected.

Either include fetchExecutionHistory in the deps (safe here since the effect always calls it without a cursor), or add an eslint-disable comment explaining why.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud
Copy link
Copy Markdown

@anuj-kumary anuj-kumary merged commit 28f1fb3 into main Apr 23, 2026
54 of 55 checks passed
@anuj-kumary anuj-kumary deleted the issue-#3391 branch April 23, 2026 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants