Skip to content

Fix #27641: using sql alchemy rows old-style#27643

Merged
edg956 merged 1 commit intomainfrom
issue-27641
Apr 23, 2026
Merged

Fix #27641: using sql alchemy rows old-style#27643
edg956 merged 1 commit intomainfrom
issue-27641

Conversation

@edg956
Copy link
Copy Markdown
Contributor

@edg956 edg956 commented Apr 22, 2026

Describe your changes:

Fixes #27641

I applied a missing change after upgrading to SQL Alchemy 2.0, because the previous syntax to build dicts from Rows change from dict(row) to dict(row._asdict())

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Summary by Gitar

  • Testing:
    • Added test_it_turns_sql_alchemy_response_to_snowflake_query_log_entries to verify correct parsing of query log results.

This will update automatically on new commits.

@edg956 edg956 requested a review from a team as a code owner April 22, 2026 19:15
@edg956 edg956 added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Apr 22, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 22, 2026

🟡 Playwright Results — all passed (13 flaky)

✅ 3698 passed · ❌ 0 failed · 🟡 13 flaky · ⏭️ 89 skipped

Shard Passed Failed Flaky Skipped
✅ Shard 1 481 0 0 4
🟡 Shard 2 655 0 1 7
🟡 Shard 3 663 0 3 1
🟡 Shard 4 646 0 2 27
✅ Shard 5 611 0 0 42
🟡 Shard 6 642 0 7 8
🟡 13 flaky test(s) (passed on retry)
  • Features/BulkEditEntity.spec.ts › Glossary (shard 2, 1 retry)
  • Features/RTL.spec.ts › Verify Following widget functionality (shard 3, 1 retry)
  • Flow/CustomizeWidgets.spec.ts › Data Products Widget (shard 3, 1 retry)
  • Flow/PersonaDeletionUserProfile.spec.ts › User profile loads correctly before and after persona deletion (shard 3, 1 retry)
  • Pages/Customproperties-part2.spec.ts › entityReferenceList shows item count, scrollable list, no expand toggle (shard 4, 1 retry)
  • Pages/DataContractsSemanticRules.spec.ts › Validate Description Rule Is_Not_Set (shard 4, 1 retry)
  • Pages/Lineage/DataAssetLineage.spec.ts › verify create lineage for entity - Table (shard 6, 1 retry)
  • Pages/Lineage/DataAssetLineage.spec.ts › verify create lineage for entity - Dashboard (shard 6, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
  • Pages/Lineage/LineageRightPanel.spec.ts › Verify custom properties tab IS visible for supported type: searchIndex (shard 6, 1 retry)
  • Pages/Users.spec.ts › Create and Delete user (shard 6, 1 retry)
  • Pages/Users.spec.ts › Permissions for table details page for Data Consumer (shard 6, 1 retry)
  • Pages/Users.spec.ts › Check permissions for Data Steward (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

This is because after ugprading to SQL Alchemy 2.0 the previous syntax to build `dict`s from `Row`s change from `dict(row)` to `dict(row._asdict())`
@edg956 edg956 enabled auto-merge (squash) April 23, 2026 09:43
@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented Apr 23, 2026

Code Review ✅ Approved

Updates the database access layer to use modern SQLAlchemy row handling, resolving the legacy compatibility issue. No additional issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud
Copy link
Copy Markdown

@edg956 edg956 merged commit ca8dd1e into main Apr 23, 2026
48 checks passed
@edg956 edg956 deleted the issue-27641 branch April 23, 2026 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ingestion safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bad SQL Alchemy Row conversion breaks Snowflake's system metric profiling

2 participants