Skip to content

fix(ui): Padding in DQ dashboard under domains and glossary tab#27663

Merged
shah-harshit merged 2 commits intomainfrom
issue-3779
Apr 23, 2026
Merged

fix(ui): Padding in DQ dashboard under domains and glossary tab#27663
shah-harshit merged 2 commits intomainfrom
issue-3779

Conversation

@shah-harshit
Copy link
Copy Markdown
Contributor

@shah-harshit shah-harshit commented Apr 23, 2026

Describe your changes:

Fixes 3799

Issue
Screenshot 2026-04-23 at 3 28 22 PM
Screenshot 2026-04-23 at 3 28 42 PM

Fix
Screenshot 2026-04-23 at 3 29 17 PM
Screenshot 2026-04-23 at 3 29 31 PM

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Summary by Gitar

  • Test fixes:
    • Updated DomainClassBase.test.ts to reflect the removal of the tw:mt-2 class in the DQ tab.

This will update automatically on new commits.

@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented Apr 23, 2026

Code Review ✅ Approved

Adjusts CSS padding for the DQ dashboard within the domains and glossary tabs to ensure consistent UI alignment. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@github-actions
Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 61%
62.01% (60373/97356) 42% (31635/75304) 45% (9502/21112)

@sonarqubecloud
Copy link
Copy Markdown

@shah-harshit shah-harshit merged commit 7e39336 into main Apr 23, 2026
47 checks passed
@shah-harshit shah-harshit deleted the issue-3779 branch April 23, 2026 12:28
@github-actions
Copy link
Copy Markdown
Contributor

🟡 Playwright Results — all passed (16 flaky)

✅ 3695 passed · ❌ 0 failed · 🟡 16 flaky · ⏭️ 89 skipped

Shard Passed Failed Flaky Skipped
🟡 Shard 1 479 0 2 4
🟡 Shard 2 653 0 3 7
🟡 Shard 3 663 0 3 1
🟡 Shard 4 646 0 2 27
🟡 Shard 5 609 0 2 42
🟡 Shard 6 645 0 4 8
🟡 16 flaky test(s) (passed on retry)
  • Pages/Customproperties-part1.spec.ts › Duration (shard 1, 1 retry)
  • Pages/UserCreationWithPersona.spec.ts › Create user with persona and verify on profile (shard 1, 1 retry)
  • Features/BulkEditEntity.spec.ts › Glossary (shard 2, 1 retry)
  • Features/CuratedAssets.spec.ts › Test Containers with display name filter (shard 2, 1 retry)
  • Features/Glossary/GlossaryP3Tests.spec.ts › should handle multiple rapid API calls (shard 2, 1 retry)
  • Features/RestoreEntityInheritedFields.spec.ts › Validate restore with Inherited domain and data products assigned (shard 3, 1 retry)
  • Features/RTL.spec.ts › Verify Following widget functionality (shard 3, 1 retry)
  • Features/Workflows/WorkflowOssRestrictions.spec.ts › save-node-configuration-button closes sidebar (local state update) (shard 3, 1 retry)
  • Pages/Customproperties-part2.spec.ts › entityReferenceList shows item count, scrollable list, no expand toggle (shard 4, 1 retry)
  • Pages/DataContractsSemanticRules.spec.ts › Validate Description Rule Is_Not_Set (shard 4, 1 retry)
  • Pages/ExplorePageRightPanel.spec.ts › Should perform CRUD and Removal operations for databaseSchema (shard 5, 1 retry)
  • Pages/Glossary.spec.ts › Add and Remove Assets (shard 5, 2 retries)
  • Pages/HyperlinkCustomProperty.spec.ts › should show No Data placeholder when hyperlink has no value (shard 6, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
  • Pages/Lineage/LineageRightPanel.spec.ts › Verify custom properties tab IS visible for supported type: searchIndex (shard 6, 1 retry)
  • Pages/Users.spec.ts › Permissions for table details page for Data Consumer (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants