Skip to content

Add relevent terms relation in term details page#27751

Merged
anuj-kumary merged 9 commits intomainfrom
issue-#27750
Apr 27, 2026
Merged

Add relevent terms relation in term details page#27751
anuj-kumary merged 9 commits intomainfrom
issue-#27750

Conversation

@anuj-kumary
Copy link
Copy Markdown
Member

@anuj-kumary anuj-kumary commented Apr 27, 2026

Describe your changes:

Added relevant term relations in the Term Details page displays only relations associated with the selected term
Removed search-highlighted elements from the graph. Graph now displays only the actual result set, reducing visual noise

Screen.Recording.2026-04-27.at.11.37.05.AM.mov
Screen.Recording.2026-04-27.at.11.38.13.AM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Summary by Gitar

  • Test refactoring:
    • Moved ontology filter tests to OntologyExplorerFilters.spec.ts for improved modularity and maintenance
    • Cleaned up and streamlined OntologyExplorer.spec.ts after migrating test suites

This will update automatically on new commits.

@anuj-kumary anuj-kumary self-assigned this Apr 27, 2026
@anuj-kumary anuj-kumary requested a review from a team as a code owner April 27, 2026 06:25
@anuj-kumary anuj-kumary added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Apr 27, 2026
siddhant1
siddhant1 previously approved these changes Apr 27, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 27, 2026

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 61%
62.05% (61924/99793) 42.14% (33109/78563) 45.23% (9802/21671)

siddhant1
siddhant1 previously approved these changes Apr 27, 2026
@anuj-kumary anuj-kumary enabled auto-merge (squash) April 27, 2026 08:16
@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented Apr 27, 2026

Code Review ✅ Approved 1 resolved / 1 findings

Integrates relevant terms relations into the term details page. Resolves the issue where the combo label incorrectly dropped the glossary displayName in the fallback path.

✅ 1 resolved
Bug: Combo label drops glossary displayName in fallback path

📄 openmetadata-ui/src/main/resources/ui/src/components/OntologyExplorer/hooks/useGraphData.ts:724-725
In useGraphData.ts line 725, the combo name fallback changed from glossary.displayName || glossary.name to just glossary.name. While terms[0].group (checked first via ??) usually carries the displayName from the builder, when group is undefined (e.g., nodes from convertRdfGraphToOntologyGraph where node.group is not set), the combo label will now show the internal name instead of the human-friendly displayName. This is a minor UI regression for glossaries that have a distinct displayName.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud
Copy link
Copy Markdown

@anuj-kumary anuj-kumary merged commit fb0d5ec into main Apr 27, 2026
49 checks passed
@anuj-kumary anuj-kumary deleted the issue-#27750 branch April 27, 2026 12:50
@github-actions
Copy link
Copy Markdown
Contributor

🟡 Playwright Results — all passed (11 flaky)

✅ 3960 passed · ❌ 0 failed · 🟡 11 flaky · ⏭️ 86 skipped

Shard Passed Failed Flaky Skipped
🟡 Shard 1 298 0 1 4
🟡 Shard 2 747 0 3 8
🟡 Shard 3 738 0 1 7
🟡 Shard 4 756 0 3 18
✅ Shard 5 687 0 0 41
🟡 Shard 6 734 0 3 8
🟡 11 flaky test(s) (passed on retry)
  • Pages/UserCreationWithPersona.spec.ts › Create user with persona and verify on profile (shard 1, 1 retry)
  • Features/ActivityAPI.spec.ts › Activity event is created when description is updated (shard 2, 1 retry)
  • Features/ActivityAPI.spec.ts › Activity event is created when owner is added (shard 2, 1 retry)
  • Features/IncidentManager.spec.ts › Complete Incident lifecycle with table owner (shard 2, 1 retry)
  • Features/RTL.spec.ts › Verify Following widget functionality (shard 3, 1 retry)
  • Pages/DataContracts.spec.ts › Create Data Contract and validate for Database (shard 4, 1 retry)
  • Pages/DomainAdvanced.spec.ts › Filter assets by domain from explore page (shard 4, 1 retry)
  • Pages/Domains.spec.ts › Domain Rbac (shard 4, 1 retry)
  • Features/AutoPilot.spec.ts › Agents created by AutoPilot should be deleted (shard 6, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
  • Pages/Lineage/LineageRightPanel.spec.ts › Verify custom properties tab IS visible for supported type: searchIndex (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

anuj-kumary added a commit that referenced this pull request Apr 27, 2026
* Add relevent terms relation in term details page

* fix lint issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show only relevant filters on terms details page in Ontology Explorer

2 participants