chore: update sqlalchemy to 1.0.0#27776
Conversation
Code Review ✅ ApprovedUpdates the SQLAlchemy dependency to version 1.0.0. No issues were found. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
There was a problem hiding this comment.
Pull request overview
Updates the ingestion build/install setup for the Redshift SQLAlchemy dialect by moving sqlalchemy-redshift installation into the redshift extra and removing the special-case preinstall from CI images/actions.
Changes:
- Add
sqlalchemy-redshift~=1.0.0to theredshiftextra iningestion/setup.py. - Remove
sqlalchemy-redshift==0.8.14from the “pre-install dialect packages” steps in ingestion CI Dockerfiles. - Remove
sqlalchemy-redshift==0.8.14from the composite GitHub Action’s dependency bootstrap.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ingestion/setup.py | Adds sqlalchemy-redshift to the Redshift plugin extra so it’s installed via pip install ingestion[redshift] / ingestion[all]. |
| ingestion/operators/docker/Dockerfile.ci | Stops preinstalling sqlalchemy-redshift with --no-deps during CI image build. |
| ingestion/Dockerfile.ci | Same as above for the main ingestion CI image. |
| .github/actions/setup-openmetadata-test-environment/action.yml | Stops preinstalling sqlalchemy-redshift in the test environment bootstrap step. |
| "redshift": { | ||
| # sqlalchemy-redshift is pre-installed with --no-deps (SA<2 metadata conflict) | ||
| "sqlalchemy-redshift~=1.0.0", |
There was a problem hiding this comment.
PR description is still the template text (e.g., "Fixes ") and doesn’t explain the actual change. Also, the PR title mentions updating "sqlalchemy" to 1.0.0, but this diff updates the Redshift dialect dependency (sqlalchemy-redshift) instead; please align the title/description with what’s actually being changed and link the issue if applicable.
|
🔴 Playwright Results — 1 failure(s), 21 flaky✅ 3663 passed · ❌ 1 failed · 🟡 21 flaky · ⏭️ 89 skipped
Genuine Failures (failed on all attempts)❌
|
(cherry picked from commit 11e5ac9)



Describe your changes:
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>Summary by Gitar
sqlalchemy-redshift==0.8.14from CI environment configuration and Docker build files.sqlalchemy-redshift~=1.0.0toingestion/setup.pyto align with the SQLAlchemy update.This will update automatically on new commits.