Skip to content

chore: update sqlalchemy to 1.0.0#27776

Merged
TeddyCr merged 1 commit intoopen-metadata:mainfrom
TeddyCr:MINOR-Redshift-Upgrade
Apr 28, 2026
Merged

chore: update sqlalchemy to 1.0.0#27776
TeddyCr merged 1 commit intoopen-metadata:mainfrom
TeddyCr:MINOR-Redshift-Upgrade

Conversation

@TeddyCr
Copy link
Copy Markdown
Collaborator

@TeddyCr TeddyCr commented Apr 28, 2026

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Summary by Gitar

  • Dependency management:
    • Removed sqlalchemy-redshift==0.8.14 from CI environment configuration and Docker build files.
    • Added sqlalchemy-redshift~=1.0.0 to ingestion/setup.py to align with the SQLAlchemy update.

This will update automatically on new commits.

Copilot AI review requested due to automatic review settings April 28, 2026 01:39
@TeddyCr TeddyCr requested review from a team, akash-jain-10, harshach and tutte as code owners April 28, 2026 01:39
@github-actions github-actions Bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Apr 28, 2026
@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented Apr 28, 2026

Code Review ✅ Approved

Updates the SQLAlchemy dependency to version 1.0.0. No issues were found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the ingestion build/install setup for the Redshift SQLAlchemy dialect by moving sqlalchemy-redshift installation into the redshift extra and removing the special-case preinstall from CI images/actions.

Changes:

  • Add sqlalchemy-redshift~=1.0.0 to the redshift extra in ingestion/setup.py.
  • Remove sqlalchemy-redshift==0.8.14 from the “pre-install dialect packages” steps in ingestion CI Dockerfiles.
  • Remove sqlalchemy-redshift==0.8.14 from the composite GitHub Action’s dependency bootstrap.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
ingestion/setup.py Adds sqlalchemy-redshift to the Redshift plugin extra so it’s installed via pip install ingestion[redshift] / ingestion[all].
ingestion/operators/docker/Dockerfile.ci Stops preinstalling sqlalchemy-redshift with --no-deps during CI image build.
ingestion/Dockerfile.ci Same as above for the main ingestion CI image.
.github/actions/setup-openmetadata-test-environment/action.yml Stops preinstalling sqlalchemy-redshift in the test environment bootstrap step.

Comment thread ingestion/setup.py
Comment on lines 358 to +359
"redshift": {
# sqlalchemy-redshift is pre-installed with --no-deps (SA<2 metadata conflict)
"sqlalchemy-redshift~=1.0.0",
Copy link

Copilot AI Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is still the template text (e.g., "Fixes ") and doesn’t explain the actual change. Also, the PR title mentions updating "sqlalchemy" to 1.0.0, but this diff updates the Redshift dialect dependency (sqlalchemy-redshift) instead; please align the title/description with what’s actually being changed and link the issue if applicable.

Copilot uses AI. Check for mistakes.
@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 28, 2026

🔴 Playwright Results — 1 failure(s), 21 flaky

✅ 3663 passed · ❌ 1 failed · 🟡 21 flaky · ⏭️ 89 skipped

Shard Passed Failed Flaky Skipped
🟡 Shard 1 478 0 2 4
🔴 Shard 2 648 1 2 7
🟡 Shard 3 655 0 5 1
🟡 Shard 4 629 0 5 27
🟡 Shard 5 610 0 1 42
🟡 Shard 6 643 0 6 8

Genuine Failures (failed on all attempts)

Features/ActivityFeed.spec.ts › Mention notification shows correct user details in Notification box (shard 2)
Error: �[2mexpect(�[22m�[31mlocator�[39m�[2m).�[22mtoBeVisible�[2m(�[22m�[2m)�[22m failed

Locator: locator('[data-testid="message-container"]').filter({ hasText: 'Initial conversation thread for mention test' }).first()
Expected: visible
Timeout: 30000ms
Error: element(s) not found

Call log:
�[2m  - Expect "toBeVisible" with timeout 30000ms�[22m
�[2m  - waiting for locator('[data-testid="message-container"]').filter({ hasText: 'Initial conversation thread for mention test' }).first()�[22m

🟡 21 flaky test(s) (passed on retry)
  • Flow/Tour.spec.ts › Tour should work from welcome screen (shard 1, 1 retry)
  • Pages/UserCreationWithPersona.spec.ts › Create user with persona and verify on profile (shard 1, 1 retry)
  • Features/ChangeSummaryBadge.spec.ts › Automated badge should appear on entity description with Automated source (shard 2, 1 retry)
  • Features/Glossary/GlossaryHierarchy.spec.ts › should cancel move operation (shard 2, 1 retry)
  • Features/RestoreEntityInheritedFields.spec.ts › Validate restore with Inherited domain and data products assigned (shard 3, 1 retry)
  • Features/RestoreEntityInheritedFields.spec.ts › Validate restore with Inherited domain and data products assigned (shard 3, 1 retry)
  • Features/RestoreEntityInheritedFields.spec.ts › Validate restore with Inherited domain and data products assigned (shard 3, 1 retry)
  • Features/RTL.spec.ts › Verify Following widget functionality (shard 3, 1 retry)
  • Flow/AddRoleAndAssignToUser.spec.ts › Verify assigned role to new user (shard 3, 1 retry)
  • Pages/Customproperties-part2.spec.ts › entityReferenceList shows item count, scrollable list, no expand toggle (shard 4, 1 retry)
  • Pages/DataContracts.spec.ts › Create Data Contract and validate for DashboardDataModel (shard 4, 1 retry)
  • Pages/DataContracts.spec.ts › Create Data Contract and validate for Container (shard 4, 1 retry)
  • Pages/DataContracts.spec.ts › Create Data Contract and validate for Database Schema (shard 4, 1 retry)
  • Pages/DataContracts.spec.ts › Add and update Security and SLA tabs (shard 4, 1 retry)
  • Pages/Glossary.spec.ts › Add and Remove Assets (shard 5, 2 retries)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
  • Pages/Lineage/LineageRightPanel.spec.ts › Verify custom properties tab IS visible for supported type: searchIndex (shard 6, 1 retry)
  • Pages/ODCSImportExportPermissions.spec.ts › User with EditAll can export ODCS contract (shard 6, 1 retry)
  • Pages/Users.spec.ts › Permissions for table details page for Data Consumer (shard 6, 1 retry)
  • Pages/Users.spec.ts › Check permissions for Data Steward (shard 6, 1 retry)
  • VersionPages/EntityVersionPages.spec.ts › Directory (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@TeddyCr TeddyCr merged commit 11e5ac9 into open-metadata:main Apr 28, 2026
62 of 67 checks passed
TeddyCr added a commit that referenced this pull request May 1, 2026
jatinmasaram pushed a commit to jatinmasaram/OpenMetadata that referenced this pull request May 2, 2026
jaya6400 pushed a commit to jaya6400/OpenMetadata that referenced this pull request May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ingestion safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants