Skip to content

Fixes 604: fix nls icon for safari#27783

Merged
shrabantipaul-collate merged 5 commits intomainfrom
fix-nls-icon-safari
Apr 29, 2026
Merged

Fixes 604: fix nls icon for safari#27783
shrabantipaul-collate merged 5 commits intomainfrom
fix-nls-icon-safari

Conversation

@shrabantipaul-collate
Copy link
Copy Markdown
Contributor

@shrabantipaul-collate shrabantipaul-collate commented Apr 28, 2026

Describe your changes:

Fix NLS icon rendering in Safari on landing page

  • GlobalSearchBar, CustomiseSearchBar, and Suggestions all inline the same SVG icons as React components simultaneously. Safari resolves url(#id) references globally across the document — unlike Chrome — so multiple instances in the DOM created duplicate IDs that caused the NLS icon to render with a broken/washed-out appearance when navigating from the landing page.

  • ic-suggestions-blue.svg — Removed the wrapper and . The clip path was a 14×14 rect on a 14×14 viewBox, a complete no-op, so removal has zero visual impact but eliminates the duplicate ID from the DOM.

  • ic-suggestions-active.svg — Converted the radial gradient from gradientUnits="userSpaceOnUse" to gradientUnits="objectBoundingBox" with mathematically equivalent coordinates (cx="-0.051" cy="0.5" r="1.2202"). With OBB, the gradient is always computed relative to the bounding box of the element being painted, not the SVG instance that happens to define it — so Safari's cross-instance ID resolution no longer produces wrong coordinates.

Fixes https://github.com/open-metadata/ai-platform/issues/604

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Summary by Gitar

  • Security/Cleanup:
    • Removed logger.info call in sas connector to prevent accidental leakage of user passwords.
    • Replaced pylint with expanded ruff configuration for improved ingestion code quality.

This will update automatically on new commits.

@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented Apr 28, 2026

Code Review ✅ Approved

Adjusts the NLS icon styling to ensure proper rendering in Safari. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@github-actions
Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 61%
62.09% (62240/100235) 42.27% (33363/78923) 45.32% (9891/21823)

@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

🟡 Playwright Results — all passed (11 flaky)

✅ 3964 passed · ❌ 0 failed · 🟡 11 flaky · ⏭️ 86 skipped

Shard Passed Failed Flaky Skipped
✅ Shard 1 299 0 0 4
🟡 Shard 2 742 0 3 8
🟡 Shard 3 747 0 1 7
🟡 Shard 4 757 0 2 18
✅ Shard 5 687 0 0 41
🟡 Shard 6 732 0 5 8
🟡 11 flaky test(s) (passed on retry)
  • Features/ActivityAPI.spec.ts › Activity event is created when description is updated (shard 2, 1 retry)
  • Features/ActivityAPI.spec.ts › Activity event shows the actor who made the change (shard 2, 1 retry)
  • Features/Glossary/GlossaryWorkflow.spec.ts › should display correct status badge color and icon (shard 2, 2 retries)
  • Features/RTL.spec.ts › Verify Following widget functionality (shard 3, 1 retry)
  • Pages/DataContracts.spec.ts › Create Data Contract and validate for ApiEndpoint (shard 4, 1 retry)
  • Pages/Entity.spec.ts › Tier Add, Update and Remove (shard 4, 1 retry)
  • Features/AutoPilot.spec.ts › Create Service and check the AutoPilot status (shard 6, 1 retry)
  • Pages/Glossary.spec.ts › Column dropdown drag-and-drop functionality for Glossary Terms table (shard 6, 1 retry)
  • Pages/GlossaryImportExport.spec.ts › Glossary Bulk Import Export (shard 6, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
  • Pages/ServiceEntity.spec.ts › Delete Database Service (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@shrabantipaul-collate shrabantipaul-collate merged commit 0fdb82d into main Apr 29, 2026
47 checks passed
@shrabantipaul-collate shrabantipaul-collate deleted the fix-nls-icon-safari branch April 29, 2026 05:15
shrabantipaul-collate added a commit that referenced this pull request Apr 29, 2026
Co-authored-by: Shrabanti Paul <shrabantipaul@Shrabantis-MacBook-Pro.local>
jatinmasaram pushed a commit to jatinmasaram/OpenMetadata that referenced this pull request May 2, 2026
Co-authored-by: Shrabanti Paul <shrabantipaul@Shrabantis-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants