Fixes 604: fix nls icon for safari#27783
Merged
shrabantipaul-collate merged 5 commits intomainfrom Apr 29, 2026
Merged
Conversation
Code Review ✅ ApprovedAdjusts the NLS icon styling to ensure proper rendering in Safari. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
Contributor
|
Contributor
🟡 Playwright Results — all passed (11 flaky)✅ 3964 passed · ❌ 0 failed · 🟡 11 flaky · ⏭️ 86 skipped
🟡 11 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
karanh37
approved these changes
Apr 29, 2026
shrabantipaul-collate
added a commit
that referenced
this pull request
Apr 29, 2026
Co-authored-by: Shrabanti Paul <shrabantipaul@Shrabantis-MacBook-Pro.local>
jatinmasaram
pushed a commit
to jatinmasaram/OpenMetadata
that referenced
this pull request
May 2, 2026
Co-authored-by: Shrabanti Paul <shrabantipaul@Shrabantis-MacBook-Pro.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Describe your changes:
Fix NLS icon rendering in Safari on landing page
GlobalSearchBar, CustomiseSearchBar, and Suggestions all inline the same SVG icons as React components simultaneously. Safari resolves url(#id) references globally across the document — unlike Chrome — so multiple instances in the DOM created duplicate IDs that caused the NLS icon to render with a broken/washed-out appearance when navigating from the landing page.
ic-suggestions-blue.svg — Removed the wrapper and . The clip path was a 14×14 rect on a 14×14 viewBox, a complete no-op, so removal has zero visual impact but eliminates the duplicate ID from the DOM.
ic-suggestions-active.svg — Converted the radial gradient from gradientUnits="userSpaceOnUse" to gradientUnits="objectBoundingBox" with mathematically equivalent coordinates (cx="-0.051" cy="0.5" r="1.2202"). With OBB, the gradient is always computed relative to the bounding box of the element being painted, not the SVG instance that happens to define it — so Safari's cross-instance ID resolution no longer produces wrong coordinates.
Fixes https://github.com/open-metadata/ai-platform/issues/604
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>Summary by Gitar
logger.infocall insasconnector to prevent accidental leakage of user passwords.pylintwith expandedruffconfiguration for improved ingestion code quality.This will update automatically on new commits.