Skip to content

fix: resolve .keyword suffix in hyperlink workflow rules and Tags/Tier field display ambiguity in check condition#27799

Merged
Rohit0301 merged 5 commits intomainfrom
fix-3734
Apr 30, 2026
Merged

fix: resolve .keyword suffix in hyperlink workflow rules and Tags/Tier field display ambiguity in check condition#27799
Rohit0301 merged 5 commits intomainfrom
fix-3734

Conversation

@Rohit0301
Copy link
Copy Markdown
Contributor

@Rohit0301 Rohit0301 commented Apr 28, 2026

Describe your changes:

Fixes 3734
playwright tests - https://github.com/open-metadata/openmetadata-collate/pull/3914

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Summary by Gitar

  • Bug fixes:
    • Removed .keyword suffix from subfieldsKey in hyperlink-cp search workflow rules.
    • Updated subfieldsKey generation for table columns to remove unnecessary .keyword suffix, ensuring consistent field mapping.

This will update automatically on new commits.

…r field display ambiguity in check condition
@Rohit0301 Rohit0301 self-assigned this Apr 28, 2026
@Rohit0301 Rohit0301 requested a review from a team as a code owner April 28, 2026 17:27
@Rohit0301 Rohit0301 added safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch labels Apr 28, 2026
@Rohit0301 Rohit0301 changed the title fix: resolve .keyword suffix in hyperlink workflow rules and Tags/Tie… fix: resolve .keyword suffix in hyperlink workflow rules and Tags/Tier field display ambiguity in check condition Apr 28, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 28, 2026

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 61%
62.1% (62278/100285) 42.27% (33375/78944) 45.31% (9896/21837)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 28, 2026

🟡 Playwright Results — all passed (11 flaky)

✅ 3974 passed · ❌ 0 failed · 🟡 11 flaky · ⏭️ 86 skipped

Shard Passed Failed Flaky Skipped
✅ Shard 1 299 0 0 4
🟡 Shard 2 750 0 4 8
🟡 Shard 3 748 0 1 7
🟡 Shard 4 758 0 1 18
🟡 Shard 5 686 0 1 41
🟡 Shard 6 733 0 4 8
🟡 11 flaky test(s) (passed on retry)
  • Features/ActivityAPI.spec.ts › Activity event is created when description is updated (shard 2, 1 retry)
  • Features/ActivityAPI.spec.ts › Activity event shows the actor who made the change (shard 2, 1 retry)
  • Features/Glossary/GlossaryWorkflow.spec.ts › should start term as Draft when glossary has reviewers (shard 2, 1 retry)
  • Features/ImpactAnalysis.spec.ts › Verify Downstream connections (shard 2, 1 retry)
  • Features/RTL.spec.ts › Verify Following widget functionality (shard 3, 1 retry)
  • Pages/DataContractsSemanticRules.spec.ts › Validate Description Rule Is_Set (shard 4, 1 retry)
  • Pages/EntityDataSteward.spec.ts › Tier Add, Update and Remove (shard 5, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
  • Pages/Lineage/LineageRightPanel.spec.ts › Verify custom properties tab IS visible for supported type: searchIndex (shard 6, 1 retry)
  • Pages/ServiceEntity.spec.ts › Delete Database Schema (shard 6, 1 retry)
  • Pages/Users.spec.ts › Check permissions for Data Steward (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

Comment thread openmetadata-ui/src/main/resources/ui/src/utils/AdvancedSearchClassBase.ts Outdated
aniketkatkar97
aniketkatkar97 previously approved these changes Apr 29, 2026
@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented Apr 29, 2026

Code Review ✅ Approved 1 resolved / 1 findings

Updates hyperlink workflow rules and check condition displays by removing unconditional .keyword suffixes. No issues found.

✅ 1 resolved
Bug: table-cp case still hardcodes .keyword unconditionally

📄 openmetadata-ui/src/main/resources/ui/src/utils/AdvancedSearchClassBase.ts:1434
The hyperlink-cp case was correctly fixed to conditionally append .keyword based on searchOutputType, but the table-cp case at line 1434 still unconditionally appends .keyword to subfieldsKey. This is the same bug pattern that was just fixed for hyperlink-cp — when searchOutputType is not ElasticSearch, the .keyword suffix should be omitted.

Since this PR is specifically addressing the .keyword suffix issue, it would be good to fix table-cp in the same change to avoid a follow-up bug report.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud
Copy link
Copy Markdown

@Rohit0301 Rohit0301 merged commit 0bd108b into main Apr 30, 2026
54 of 55 checks passed
@Rohit0301 Rohit0301 deleted the fix-3734 branch April 30, 2026 06:30
@github-actions
Copy link
Copy Markdown
Contributor

Changes have been cherry-picked to the 1.13 branch.

github-actions Bot pushed a commit that referenced this pull request Apr 30, 2026
…r field display ambiguity in check condition (#27799)

* fix: resolve .keyword suffix in hyperlink workflow rules and Tags/Tier field display ambiguity in check condition

* fixed .keyword issue for table cp

* removed irrelavent .keyword suffix

* fixed unit test

(cherry picked from commit 0bd108b)
@github-actions
Copy link
Copy Markdown
Contributor

Changes have been cherry-picked to the 1.12.7 branch.

github-actions Bot pushed a commit that referenced this pull request Apr 30, 2026
…r field display ambiguity in check condition (#27799)

* fix: resolve .keyword suffix in hyperlink workflow rules and Tags/Tier field display ambiguity in check condition

* fixed .keyword issue for table cp

* removed irrelavent .keyword suffix

* fixed unit test

(cherry picked from commit 0bd108b)
mohitjeswani01 pushed a commit to mohitjeswani01/OpenMetadata that referenced this pull request Apr 30, 2026
…r field display ambiguity in check condition (open-metadata#27799)

* fix: resolve .keyword suffix in hyperlink workflow rules and Tags/Tier field display ambiguity in check condition

* fixed .keyword issue for table cp

* removed irrelavent .keyword suffix

* fixed unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants