Skip to content

Fixed flaky entity data steward spec#27829

Merged
Rohit0301 merged 3 commits intomainfrom
fix-entity-data-steward
Apr 30, 2026
Merged

Fixed flaky entity data steward spec#27829
Rohit0301 merged 3 commits intomainfrom
fix-entity-data-steward

Conversation

@Rohit0301
Copy link
Copy Markdown
Contributor

@Rohit0301 Rohit0301 commented Apr 29, 2026

Describe your changes:

Fixes

I worked on ... because ...

Screenshot 2026-04-29 at 10 46 50 PM

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Summary by Gitar

  • Test reliability:
    • Added synchronization checks to removeTag, removeTagsFromChildren, assignGlossaryTerm, removeGlossaryTerm, and removeGlossaryTermFromChildren in entity.ts.
    • Introduced explicit waits for the saveAssociatedTag loading icon to detach before asserting visibility changes to reduce test flakiness.

This will update automatically on new commits.

Co-authored-by: Copilot <copilot@github.com>
@Rohit0301 Rohit0301 self-assigned this Apr 29, 2026
@Rohit0301 Rohit0301 requested a review from a team as a code owner April 29, 2026 16:44
@Rohit0301 Rohit0301 added the safe to test Add this label to run secure Github workflows on PRs label Apr 29, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 29, 2026

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 61%
62.06% (62310/100391) 42.25% (33402/79049) 45.3% (9904/21862)

@Rohit0301 Rohit0301 changed the title Fixed entity data steward spec Fixed flaky entity data steward spec Apr 29, 2026
@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented Apr 29, 2026

Code Review ✅ Approved

Updated the entity data steward specification to ensure correct field mapping. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

🟡 Playwright Results — all passed (14 flaky)

✅ 3984 passed · ❌ 0 failed · 🟡 14 flaky · ⏭️ 86 skipped

Shard Passed Failed Flaky Skipped
✅ Shard 1 299 0 0 4
🟡 Shard 2 751 0 3 8
🟡 Shard 3 741 0 5 7
🟡 Shard 4 773 0 2 18
✅ Shard 5 687 0 0 41
🟡 Shard 6 733 0 4 8
🟡 14 flaky test(s) (passed on retry)
  • Features/ActivityAPI.spec.ts › Activity event is created when description is updated (shard 2, 1 retry)
  • Features/ActivityAPI.spec.ts › Activity event shows the actor who made the change (shard 2, 1 retry)
  • Features/Glossary/GlossaryWorkflow.spec.ts › should start term as Draft when glossary has reviewers (shard 2, 2 retries)
  • Features/RTL.spec.ts › Verify Following widget functionality (shard 3, 1 retry)
  • Features/UserProfileOnlineStatus.spec.ts › Should show "Active recently" for users active within last hour (shard 3, 1 retry)
  • Features/Workflows/WorkflowOssRestrictions.spec.ts › delete-node-button absent in node config sidebar (structural edit blocked) (shard 3, 1 retry)
  • Flow/PersonaDeletionUserProfile.spec.ts › User profile loads correctly before and after persona deletion (shard 3, 1 retry)
  • Flow/PersonaFlow.spec.ts › Set default persona for team should work properly (shard 3, 1 retry)
  • Pages/DataContracts.spec.ts › Create Data Contract and validate for Chart (shard 4, 1 retry)
  • Pages/DataContractsSemanticRules.spec.ts › Validate DataProduct Rule Any_In (shard 4, 1 retry)
  • Pages/GlossaryImportExport.spec.ts › Glossary Bulk Import Export (shard 6, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
  • Pages/Lineage/LineageRightPanel.spec.ts › Verify custom properties tab IS visible for supported type: searchIndex (shard 6, 1 retry)
  • Pages/Users.spec.ts › Reset Password for Data Steward (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@Rohit0301 Rohit0301 merged commit 70fc7cb into main Apr 30, 2026
47 checks passed
@Rohit0301 Rohit0301 deleted the fix-entity-data-steward branch April 30, 2026 05:36
Rohit0301 added a commit that referenced this pull request Apr 30, 2026
Rohit0301 added a commit that referenced this pull request Apr 30, 2026
* Fixed entity data steward spec

Co-authored-by: Copilot <copilot@github.com>

* fixed all the utils function

---------

Co-authored-by: Copilot <copilot@github.com>
mohitjeswani01 pushed a commit to mohitjeswani01/OpenMetadata that referenced this pull request Apr 30, 2026
* Fixed entity data steward spec

Co-authored-by: Copilot <copilot@github.com>

* fixed all the utils function

---------

Co-authored-by: Copilot <copilot@github.com>
jatinmasaram pushed a commit to jatinmasaram/OpenMetadata that referenced this pull request May 2, 2026
* Fixed entity data steward spec

Co-authored-by: Copilot <copilot@github.com>

* fixed all the utils function

---------

Co-authored-by: Copilot <copilot@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants