Skip to content

Fix missing ER_DIAGRAM tab in Table and Database Schema customizePage Test#27840

Merged
chirag-madlani merged 2 commits intomainfrom
fix-customizeDetailsPage-tab-count-issue
Apr 30, 2026
Merged

Fix missing ER_DIAGRAM tab in Table and Database Schema customizePage Test#27840
chirag-madlani merged 2 commits intomainfrom
fix-customizeDetailsPage-tab-count-issue

Conversation

@shrabantipaul-collate
Copy link
Copy Markdown
Contributor

Describe your changes:

  • The Task redesign PR 25894 removed the ER_DIAGRAM tab from TABLE_DEFAULT_TABS and DATABASE_SCHEMA_DEFAULT_TABS in the playwright test constants.
  • As a result in AUT, the Collate UI still renders ER_DIAGRAM tab, but the test constants count don't expect it, causing the toHaveCount assertion to fail.
  • Restored the process.env.PLAYWRIGHT_IS_OSS conditional so OSS builds don't have the ER_DIAGRAM tab and Collate builds have it, matching what each environment actually renders.

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@shrabantipaul-collate shrabantipaul-collate requested a review from a team as a code owner April 30, 2026 07:24
@shrabantipaul-collate shrabantipaul-collate added the safe to test Add this label to run secure Github workflows on PRs label Apr 30, 2026
@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented Apr 30, 2026

Code Review ✅ Approved

Restores the missing ER_DIAGRAM tab within the Table and Database Schema customizePage tests. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@github-actions
Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 61%
62.06% (62310/100391) 42.25% (33402/79049) 45.3% (9904/21862)

@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

🟡 Playwright Results — all passed (13 flaky)

✅ 3985 passed · ❌ 0 failed · 🟡 13 flaky · ⏭️ 86 skipped

Shard Passed Failed Flaky Skipped
✅ Shard 1 299 0 0 4
🟡 Shard 2 751 0 3 8
🟡 Shard 3 744 0 2 7
🟡 Shard 4 771 0 4 18
🟡 Shard 5 686 0 1 41
🟡 Shard 6 734 0 3 8
🟡 13 flaky test(s) (passed on retry)
  • Features/ActivityAPI.spec.ts › Activity event is created when description is updated (shard 2, 1 retry)
  • Features/ActivityAPI.spec.ts › Activity event shows the actor who made the change (shard 2, 1 retry)
  • Features/Glossary/GlossaryHierarchy.spec.ts › should cancel move operation (shard 2, 1 retry)
  • Features/RTL.spec.ts › Verify Following widget functionality (shard 3, 1 retry)
  • Features/UserProfileOnlineStatus.spec.ts › Should not show online status for inactive users (shard 3, 1 retry)
  • Pages/CustomProperties.spec.ts › Should display custom properties for chart in right panel (shard 4, 1 retry)
  • Pages/DataContracts.spec.ts › Create Data Contract and validate for Topic (shard 4, 1 retry)
  • Pages/DomainUIInteractions.spec.ts › Clear domain selection returns to All Domains (shard 4, 1 retry)
  • Pages/Entity.spec.ts › Announcement create, edit & delete (shard 4, 1 retry)
  • Pages/Entity.spec.ts › Tier Add, Update and Remove (shard 5, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
  • Pages/Lineage/LineageRightPanel.spec.ts › Verify custom properties tab IS visible for supported type: searchIndex (shard 6, 1 retry)
  • Pages/Users.spec.ts › Check permissions for Data Steward (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@chirag-madlani chirag-madlani merged commit 3504ef8 into main Apr 30, 2026
47 checks passed
@chirag-madlani chirag-madlani deleted the fix-customizeDetailsPage-tab-count-issue branch April 30, 2026 10:14
mohitjeswani01 pushed a commit to mohitjeswani01/OpenMetadata that referenced this pull request Apr 30, 2026
…e tests (open-metadata#27840)

Co-authored-by: Shrabanti Paul <shrabantipaul@Shrabantis-MacBook-Pro.local>
jatinmasaram pushed a commit to jatinmasaram/OpenMetadata that referenced this pull request May 2, 2026
…e tests (open-metadata#27840)

Co-authored-by: Shrabanti Paul <shrabantipaul@Shrabantis-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants