Skip to content

fix(playwright): support selecting explore left panel asset type#27887

Merged
harsh-vador merged 2 commits intomainfrom
add-dataset-type-select-spec
May 4, 2026
Merged

fix(playwright): support selecting explore left panel asset type#27887
harsh-vador merged 2 commits intomainfrom
add-dataset-type-select-spec

Conversation

@harsh-vador
Copy link
Copy Markdown
Contributor

@harsh-vador harsh-vador commented May 4, 2026

Describe your changes:

Description

Adds optional support in the Explore Playwright helpers to select a specific left-panel asset type before opening an entity summary panel.

This is needed for entity types such as Knowledge Center assets, which are not covered by the existing endpoint-to-filter mapping and therefore need an explicit left-panel tab selection before locating the result card.

Screen.Recording.2026-05-04.at.7.20.28.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Summary by Gitar

  • Dependency migration:
    • Migrated Databricks from sqlalchemy-databricks to databricks-sqlalchemy.

This will update automatically on new commits.

@harsh-vador harsh-vador self-assigned this May 4, 2026
@harsh-vador harsh-vador requested a review from a team as a code owner May 4, 2026 13:42
@harsh-vador harsh-vador added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch labels May 4, 2026
@harsh-vador harsh-vador enabled auto-merge (squash) May 4, 2026 13:58
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 62%
62.45% (62922/100755) 42.77% (33911/79285) 45.77% (10035/21924)

@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented May 4, 2026

Code Review ✅ Approved

Adds support to the Explore Playwright helpers for selecting specific left-panel asset types to enable proper entity summary panel navigation. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 4, 2026

@harsh-vador harsh-vador merged commit 741603c into main May 4, 2026
46 checks passed
@harsh-vador harsh-vador deleted the add-dataset-type-select-spec branch May 4, 2026 18:28
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

🟡 Playwright Results — all passed (10 flaky)

✅ 3988 passed · ❌ 0 failed · 🟡 10 flaky · ⏭️ 86 skipped

Shard Passed Failed Flaky Skipped
✅ Shard 1 299 0 0 4
🟡 Shard 2 752 0 2 8
🟡 Shard 3 745 0 1 7
🟡 Shard 4 773 0 2 18
🟡 Shard 5 686 0 1 41
🟡 Shard 6 733 0 4 8
🟡 10 flaky test(s) (passed on retry)
  • Features/ActivityAPI.spec.ts › Activity event is created when description is updated (shard 2, 1 retry)
  • Features/ActivityAPI.spec.ts › Activity event shows the actor who made the change (shard 2, 1 retry)
  • Flow/PersonaFlow.spec.ts › Set default persona for team should work properly (shard 3, 1 retry)
  • Pages/DataContracts.spec.ts › Create Data Contract and validate for File (shard 4, 1 retry)
  • Pages/DataContractsSemanticRules.spec.ts › Validate Description Rule Is_Not_Set (shard 4, 1 retry)
  • Pages/ExplorePageRightPanel.spec.ts › Should allow Data Consumer to edit description for table (shard 5, 1 retry)
  • Pages/Glossary.spec.ts › Glossary Term Update in Glossary Page should persist tree (shard 6, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
  • Pages/Lineage/LineageRightPanel.spec.ts › Verify custom properties tab IS visible for supported type: searchIndex (shard 6, 1 retry)
  • Pages/ServiceEntity.spec.ts › Tier Add, Update and Remove (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented May 4, 2026

Code Review ✅ Approved

Adds support to the Explore Playwright helpers for selecting specific left-panel asset types to enable proper entity summary panel navigation. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Changes have been cherry-picked to the 1.13 branch.

github-actions Bot pushed a commit that referenced this pull request May 4, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Changes have been cherry-picked to the 1.12.7 branch.

github-actions Bot pushed a commit that referenced this pull request May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants