[skip ci] Skip activity api test#28070
Conversation
Mark Activity API Playwright describe blocks as fixme while async event propagation is investigated, and drop the redundant inline timeout comments. Mirrors the change in #28068 on a separate branch. Investigation TODOs are captured in code above the first fixme block. [skip ci]
github-actions
Bot
added
safe to test
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
| // Investigation needed: | ||
| // 1. Profile actual event propagation time — measure how long it typically takes from a PATCH/PUT call to the event appearing in /api/v1/activity, then tighten the ceiling. | ||
| // 2. If synchronous flushing is not feasible, restructure tests to assert entity state directly via the entity API, seed a pre-built activity event, and verify only that the UI renders it decoupling UI assertions from event latency. |
There was a problem hiding this comment.
💡 Quality: TODO comments missing ticket references
The investigation comments added at lines 45-47 describe future work but do not include a ticket/issue reference. Per project guidelines, TODOs must include ticket references so they can be tracked and not forgotten.
Consider referencing the related issue (e.g., #28068 or a dedicated tracking issue) so this fixme doesn't become permanently stale.
Add ticket reference to the TODO comment so it can be tracked:
// TODO(#28068): Investigation needed:
// 1. Profile actual event propagation time — measure how long it typically takes from a PATCH/PUT call to the event appearing in /api/v1/activity, then tighten the ceiling.
// 2. If synchronous flushing is not feasible, restructure tests to assert entity state directly via the entity API, seed a pre-built activity event, and verify only that the UI renders it decoupling UI assertions from event latency.
Was this helpful? React with 👍 / 👎
Code Review 👍 Approved with suggestions 0 resolved / 1 findingsSkips unstable Activity API Playwright suites using fixme decorators to stabilize the test environment. Ensure the added investigation TODOs are updated with tracking ticket references. 💡 Quality: TODO comments missing ticket references📄 openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/ActivityAPI.spec.ts:45-47 The investigation comments added at lines 45-47 describe future work but do not include a ticket/issue reference. Per project guidelines, TODOs must include ticket references so they can be tracked and not forgotten. Consider referencing the related issue (e.g., #28068 or a dedicated tracking issue) so this Add ticket reference to the TODO comment so it can be tracked🤖 Prompt for agentsOptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
There was a problem hiding this comment.
Pull request overview
Disables the flaky Activity API Playwright coverage by marking the Activity API suites as fixme, to avoid blocking on asynchronous activity event propagation latency while the root cause is investigated.
Changes:
- Switched the Activity API Playwright suites (
Entity Changes,Reactions,Comments,Homepage Widget) fromtest.describetotest.describe.fixme. - Removed repeated inline timeout-explanation comments and added a single investigation note at the top of the file.
| test.describe( | ||
| // Investigation needed: | ||
| // 1. Profile actual event propagation time — measure how long it typically takes from a PATCH/PUT call to the event appearing in /api/v1/activity, then tighten the ceiling. | ||
| // 2. If synchronous flushing is not feasible, restructure tests to assert entity state directly via the entity API, seed a pre-built activity event, and verify only that the UI renders it decoupling UI assertions from event latency. |
ShaileshParmar11
requested a deployment
to
test
GitHub Actions
In progress
Jest test CoverageUI tests summary
|
|
Describe your changes:
Mirrors #28068 on a separate branch. Skips the Activity API Playwright suites (
Entity Changes,Reactions,Comments,Homepage Widget) by switchingtest.describe→test.describe.fixme, and drops the duplicated inline timeout comments now that the suites are skipped.Skip CI
Commit message and PR title both include
[skip ci]per the GitHub skip-workflow-runs guide so Actions workflows are not triggered for this PR.Investigation TODOs (captured in code):
/api/v1/activity, then tighten the ceiling.Type of change:
Tests:
No new tests; this PR only marks existing suites as
fixmeuntil the async event propagation investigation lands.UI screen recording / screenshots:
Not applicable.
Checklist: