Move user profile menu items to navbar classbase#28431
Open
karanh37 wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
safe to test
Code Review ✅ ApprovedRefactors UserProfileIcon to delegate menu item construction to NavbarUtilClassBase, improving separation of concerns. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the User Profile dropdown menu construction by moving menu item generation into NavbarUtilClassBase, leaving UserProfileIcon focused on state management and rendering.
Changes:
- Added
NavbarUtilClassBase.getUserProfileIconMenuItems()andgetUserProfileIconDefaultOpenKeys()to centralize User Profile dropdown menu configuration. - Introduced
UserProfileIcon.interface.tsto hold shared prop/type definitions for menu item construction. - Simplified
UserProfileIcon.component.tsxby delegating menu item creation toNavbarUtilClassBase.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| openmetadata-ui/src/main/resources/ui/src/utils/NavbarUtilClassBase.ts | Adds centralized helpers for building the User Profile dropdown menu items and default open keys. |
| openmetadata-ui/src/main/resources/ui/src/components/Settings/Users/UserProfileIcon/UserProfileIcon.interface.ts | Introduces shared typings for menu item construction inputs. |
| openmetadata-ui/src/main/resources/ui/src/components/Settings/Users/UserProfileIcon/UserProfileIcon.component.tsx | Removes inline menu construction and delegates menu item creation to NavbarUtilClassBase. |
| readMoreLabelRenderer: (count: number) => ReactNode; | ||
| readMoreKey: string; | ||
| sizeLimit?: number; | ||
| itemKey: string; |
Comment on lines
+142
to
+147
| { | ||
| type: 'divider', | ||
| }, | ||
| { | ||
| type: 'divider', | ||
| }, |
Contributor
Jest test CoverageUI tests summary
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tests