Fixed the visit classification method by Rohit0301 · Pull Request #28636 · open-metadata/OpenMetadata

Rohit0301 · 2026-06-02T12:09:23Z

Describe your changes:

Align the visit classification method definition with main branch

Fixes #

I worked on ... because ...

Type of change:

High-level design:

N/A — small change.

Tests:

Use cases covered

Unit tests

Backend integration tests

Ingestion integration tests

Playwright (UI) tests

Manual testing performed

UI screen recording / screenshots:

Not applicable.

Checklist:

I have read the CONTRIBUTING document.
My PR title is Fixes <issue-number>: <short explanation>
My PR is linked to a GitHub issue via Fixes #<issue-number> above.
I have commented on my code, particularly in hard-to-understand areas.
For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
For UI changes: I attached a screen recording and/or screenshots above.
I have added tests (unit / integration / Playwright as applicable) and listed them above.

Summary by Gitar

Refactored Playwright utility:
- Updated visitClassificationPage in tag.ts to navigate via URL directly rather than interacting with the sidebar.
- Streamlined loader synchronization and response handling to improve test reliability.
Fixed UI interaction:
- Resolved issue where the update button click was missed when selecting an entity type filter.

_{This will update automatically on new commits.}

github-actions · 2026-06-02T12:13:09Z

❌ UI Checkstyle Failed

❌ Playwright — ESLint + Prettier + Organise Imports

One or more Playwright test files have linting or formatting issues.

❌ Core Components — ESLint + Prettier

One or more core-component files have linting or formatting issues.

Fix locally (fast — only checks files changed in this branch):

make ui-checkstyle-changed

github-actions · 2026-06-02T12:16:06Z

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

github-actions · 2026-06-02T13:44:56Z

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

github-actions · 2026-06-02T14:15:10Z

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

github-actions · 2026-06-02T16:56:49Z

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

gitar-bot · 2026-06-02T17:53:12Z

Code Review ✅ Approved

Refactors the visitClassificationPage utility to navigate via direct URL instead of sidebar interaction, improving test reliability. No issues were found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

`Compact`
`gitar display:verbose`

_{Was this helpful? React with 👍 / 👎 | Gitar}

github-actions · 2026-06-02T18:50:22Z