Skip to content

fix: resolve tooltip overlap issue in entity selection by adding hover and force click to playwright tests#28749

Open
aniketkatkar97 wants to merge 1 commit into
mainfrom
fix-service-ingestion-failure
Open

fix: resolve tooltip overlap issue in entity selection by adding hover and force click to playwright tests#28749
aniketkatkar97 wants to merge 1 commit into
mainfrom
fix-service-ingestion-failure

Conversation

@aniketkatkar97
Copy link
Copy Markdown
Member

@aniketkatkar97 aniketkatkar97 commented Jun 5, 2026

Fixes #28750
This pull request introduces a small but important improvement to the Playwright test utility for visiting entity pages. The change addresses a UI automation issue where tooltips can interfere with clicking on options, causing test failures.
The failure was frequently observed in ServiceIngestion.spec.ts runs where the option was at the bottom of the dropdown, and the table header sort tooltip was overlapping the option, causing the click operation to fail.

  • Playwright test reliability improvement:
    • In entity.ts, updated the click action on the entity name to first hover over the element and then perform a forced click. This approach helps avoid failures caused by tooltip overlaps interfering with Playwright's ability to click the option.

@aniketkatkar97 aniketkatkar97 self-assigned this Jun 5, 2026
Copilot AI review requested due to automatic review settings June 5, 2026 10:19
@aniketkatkar97 aniketkatkar97 requested a review from a team as a code owner June 5, 2026 10:19
@aniketkatkar97 aniketkatkar97 added the To release Will cherry-pick this PR into the release branch label Jun 5, 2026
@github-actions github-actions Bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Jun 5, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves Playwright E2E test stability by hardening the visitEntityPage utility against UI tooltip overlays that can block click interactions (notably in entity dropdown selections).

Changes:

  • Adds a hover step before clicking the entity option to reduce tooltip overlap.
  • Uses a forced click (with ESLint suppression) as a fallback when the element remains obstructed.

Comment on lines +84 to +93
// Adding a failsafe for the operation below to avoid a tooltip overlap issue
// over the option is causing playwright failure
// 1. To first hover over the option to move mouse away from tooltip trigger element
// 2. In case the tooltip is still there, force click on the option-.
await page.getByTestId(dataTestId).getByTestId('data-name').hover();
await page
.getByTestId(dataTestId)
.getByTestId('data-name')
// eslint-disable-next-line playwright/no-force-option
.click({ force: true });
@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented Jun 5, 2026

Code Review ✅ Approved

Updates the entity selection test utility to include hover and force click actions, resolving test flakiness caused by tooltip overlaps. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 5, 2026

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
63.37% (67205/106042) 44.29% (36968/83456) 46.71% (11124/23811)

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 5, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 5, 2026

🔴 Playwright Results — 1 failure(s), 12 flaky

✅ 4269 passed · ❌ 1 failed · 🟡 12 flaky · ⏭️ 88 skipped

Shard Passed Failed Flaky Skipped
🔴 Shard 1 300 1 0 4
🟡 Shard 2 801 0 3 9
🟡 Shard 3 805 0 2 8
🟡 Shard 4 853 0 2 12
🟡 Shard 5 720 0 1 47
🟡 Shard 6 790 0 4 8

Genuine Failures (failed on all attempts)

Pages/AuditLogs.spec.ts › should apply both User and EntityType filters simultaneously (shard 1)
�[31mTest timeout of 60000ms exceeded.�[39m
🟡 12 flaky test(s) (passed on retry)
  • Features/DataQuality/TestCaseImportExportE2eFlow.spec.ts › Admin: Complete export-import-validate flow (shard 2, 1 retry)
  • Features/DataQuality/TestCaseResultPermissions.spec.ts › User with only VIEW cannot PATCH results (shard 2, 1 retry)
  • Features/Glossary/GlossaryWorkflow.spec.ts › should display correct status badge color and icon (shard 2, 1 retry)
  • Flow/ExploreAggregationCountsMatching.spec.ts › should verify left panel counts and tab search results for normal search (shard 3, 1 retry)
  • Flow/IngestionBot.spec.ts › Ingestion bot should be able to access domain specific domain (shard 3, 2 retries)
  • Flow/PersonaFlow.spec.ts › Set default persona for team should work properly (shard 4, 1 retry)
  • Pages/CustomProperties.spec.ts › Set & Update all CP types on table (shard 4, 1 retry)
  • Pages/ExplorePageRightPanel_KnowledgeCenter.spec.ts › Should remove user owner for knowledgeCenter (shard 5, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage service type filter selection (shard 6, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
  • Pages/Lineage/LineageRightPanel.spec.ts › Verify custom properties tab IS visible for supported type: searchIndex (shard 6, 1 retry)
  • Pages/Lineage/PlatformLineage.spec.ts › Verify domain platform view (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Service Ingestion playwright flakiness

3 participants