feat(ui): extract database/schema/table tab utils and config utils#28792
Conversation
…s (PR #13) Extract tab components and config utils from large source files into dedicated modules. Original files re-export all moved symbols for backward compatibility. New files: - Database/DatabaseDropdownOptions.tsx (database dropdown option builders) - Database/DatabaseTabsUtils.tsx (database page tab definitions) - DatabaseSchemaDropdownOptions.tsx (schema dropdown option builders) - DatabaseSchemaTabsUtils.tsx (schema page tab definitions) - TableDropdownOptions.tsx (table dropdown option builders) - TableTabsUtils.tsx (table page tab definitions) - IngestionConfigUtils.ts (ingestion configuration pure utils) - CronExpressionUtils.ts (cron schedule/expression utils) - DomainFilterUtils.ts (domain filter query builders) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
…tils Removes transitive React/antd dependency from pure util IngestionConfigUtils.ts. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- TableTabsUtils: convert ActivityFeedTab from eager import to React.lazy() - Apply import type for type-only symbols across all new utils files Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Changed from import type back to value import — ActivityFeedLayoutType is an enum used at runtime (ActivityFeedLayoutType.THREE_PANEL). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
🟡 Playwright Results — all passed (14 flaky)✅ 4266 passed · ❌ 0 failed · 🟡 14 flaky · ⏭️ 88 skipped
🟡 14 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
Code Review ✅ Approved 1 resolved / 1 findingsRefactors large database and schema modules by extracting tab definitions and configuration utilities into focused files. All imports were updated to ensure backward compatibility and clean up cross-module dependencies. ✅ 1 resolved✅ Quality: Pure util IngestionConfigUtils imports from React-heavy SchedularUtils
OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |



Summary
Extract tab definitions, dropdown option builders, and configuration utilities from large source files into focused dedicated modules. All original files re-export every moved symbol for backward compatibility.
New files
Database/DatabaseDropdownOptions.tsxDatabase/Database.util.tsxDatabase/DatabaseTabsUtils.tsxDatabase/Database.util.tsxDatabaseSchemaDropdownOptions.tsxDatabaseSchemaDetailsUtils.tsxDatabaseSchemaTabsUtils.tsxDatabaseSchemaDetailsUtils.tsxTableDropdownOptions.tsxTableUtils.tsxTableTabsUtils.tsxTableUtils.tsxIngestionConfigUtils.tsIngestionUtils.tsxCronExpressionUtils.tsSchedularUtils.tsxDomainFilterUtils.tsDomainUtils.tsxGuidelines followed
.ts): no React imports, no JSX, no API calls.tsx): JSX allowed, but structured as focused modulesimport typeused for all type-only importsTest plan
npx tsc --noEmitpasses (no new errors in changed files)🤖 Generated with Claude Code