Adding topics details page by Sachin-chaurasiya · Pull Request #369 · open-metadata/OpenMetadata

Sachin-chaurasiya · 2021-09-02T10:57:22Z

Closes #366

Describe your changes :

I worked on the topics details page because the need to add a topics details page where the user can see the whole detail of the topic.

Type of change :

New feature

Frontend Preview (Screenshots) :

Checklist:

I have read the CONTRIBUTING document.
I have performed a self-review of my own.
I have tagged my reviewers below.
I have commented on my code, particularly in hard-to-understand areas.
My changes generate no new warnings.
I have added tests that prove my fix is effective or that my feature works.
All new and existing tests passed.

Reviewers

@shahsank3t, @darth-coder00,

darth-coder00 · 2021-09-02T14:14:03Z

 */

 import { AxiosResponse } from 'axios';
+import { Topic } from 'Models';


Import this from Topics under generated folder

For this PR we can use from models and we can change it in another Separate PR.

darth-coder00 · 2021-09-02T14:17:25Z

+              <>
+                {tags.slice(0, LIST_SIZE).map((tag, index) => (
+                  <Tags
+                    className="tw-bg-gray-200"


Why using tailwind color scheme for BG color?

darth-coder00 · 2021-09-02T14:21:04Z

+                <span className="">
+                  <Tags
+                    className="tw-border-main tw-text-primary"
+                    tag="+ Add new tag"


Changes Add new tag to Add tag as it gives wrong impression of being able to add custom tags on the fly

Make this change everywhere, either in this PR or make a separate PR for it

darth-coder00 · 2021-09-02T14:22:37Z

@@ -0,0 +1,22 @@
+import { getJSONFromString } from '../../utils/StringsUtils';
+
+export const JSON_TAB_SIZE = 2;


Move this to constants file

darth-coder00 · 2021-09-02T14:23:39Z

+
+export const JSON_TAB_SIZE = 2;
+
+export const getEditorValue = (value: string, autoFormat = true): string => {


Name it as getSchemaEditorValue

darth-coder00 · 2021-09-02T14:25:47Z

  };
+
+  // topic interface start
+  export interface Topic {


No need to add this interface in types.d.ts, use it directly from generated types

darth-coder00 · 2021-09-02T14:31:13Z

@@ -0,0 +1,333 @@
+import { AxiosResponse } from 'axios';
+import { compare } from 'fast-json-patch';
+import { observer } from 'mobx-react';


Why we need observer if we do not have appstate in this component?

darth-coder00 · 2021-09-02T14:31:34Z

+import { AxiosResponse } from 'axios';
+import { compare } from 'fast-json-patch';
+import { observer } from 'mobx-react';
+import { ColumnTags, TableDetail, Topic } from 'Models';


Topic from generated folder

darth-coder00

Requested few changes

darth-coder00 · 2021-09-02T14:37:29Z

Also add some max height to the container above Codemirror, in case schema is too long, scroll should come in that container after a certain height

Sachin-chaurasiya · 2021-09-02T14:44:07Z

Addressed every comment except that use types from generated types. will fix that on separate PR.

Adding topics details page

b8958c6

Sachin-chaurasiya self-assigned this Sep 2, 2021

Sachin-chaurasiya added 2 commits September 2, 2021 18:20

added spport for Avro and json mode .

619d1a0

minor style changes

d290449

Sachin-chaurasiya marked this pull request as ready for review September 2, 2021 13:20

Sachin-chaurasiya changed the title ~~[WIP] Adding topics details page~~ Adding topics details page Sep 2, 2021

Sachin-chaurasiya requested review from darth-coder00 and shahsank3t September 2, 2021 13:23

shahsank3t approved these changes Sep 2, 2021

View reviewed changes

darth-coder00 reviewed Sep 2, 2021

View reviewed changes

Comment thread ...g-rest-service/src/main/resources/ui/src/components/common/entityPageInfo/EntityPageInfo.tsx

darth-coder00 reviewed Sep 2, 2021

View reviewed changes

darth-coder00 suggested changes Sep 2, 2021

View reviewed changes

addressing review comment

e2285c0

addressing review comment

c438a7e

Merge branch 'main' into issue-366

d3a1147

darth-coder00 approved these changes Sep 3, 2021

View reviewed changes

darth-coder00 merged commit 4d3ec27 into main Sep 3, 2021

darth-coder00 deleted the issue-366 branch September 3, 2021 04:02

		@@ -0,0 +1,22 @@
		import { getJSONFromString } from '../../utils/StringsUtils';

		export const JSON_TAB_SIZE = 2;


		export const JSON_TAB_SIZE = 2;

		export const getEditorValue = (value: string, autoFormat = true): string => {

Conversation

Sachin-chaurasiya commented Sep 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your changes :

Type of change :

Frontend Preview (Screenshots) :

Checklist:

Reviewers

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

darth-coder00 left a comment

Choose a reason for hiding this comment

Uh oh!

darth-coder00 commented Sep 2, 2021

Uh oh!

Sachin-chaurasiya commented Sep 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Sachin-chaurasiya commented Sep 2, 2021 •

edited

Loading

Sachin-chaurasiya commented Sep 2, 2021 •

edited

Loading