Skip to content

MSSQL sample-data query fix#375

Merged
harshach merged 2 commits intomainfrom
issue-361
Sep 7, 2021
Merged

MSSQL sample-data query fix#375
harshach merged 2 commits intomainfrom
issue-361

Conversation

@ayush-shah
Copy link
Copy Markdown
Member

@ayush-shah ayush-shah commented Sep 2, 2021

Describe your changes :

fix #361
Limit doesn't work in MSSQL, had to override the method to use Top
Changed the pointing of different metadata sinks to one sink (metadata-rest)
Added custom query format support to override the default query format

Type of change :

  • Bug fix

Checklist:

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

@harshach

@ayush-shah ayush-shah requested a review from harshach September 2, 2021 14:50
@harshach harshach merged commit 657962b into main Sep 7, 2021
@ayush-shah ayush-shah deleted the issue-361 branch September 7, 2021 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MSSQL sample data generation is running into SQL syntax errors

2 participants