Merged
Conversation
pmbrull
reviewed
Jun 2, 2022
| "delta": DatabaseServiceType.DeltaLake.value, | ||
| "salesforce": DatabaseServiceType.Salesforce.value, | ||
| "oracle": DatabaseServiceType.Oracle.value, | ||
| } |
Collaborator
There was a problem hiding this comment.
sorry, what's the goal of this?
pmbrull
reviewed
Jun 2, 2022
| @@ -223,7 +294,7 @@ def create_dashboard_entity(self, dashboard): | |||
| service_entity = get_dashboard_service_or_create( | |||
Collaborator
There was a problem hiding this comment.
instead of get or create, we should just GET?
Collaborator
There was a problem hiding this comment.
if in the docs we specify that users should first create the services, then IMO we should:
- try to get the service
- if it is not there, throw an exception calling out that "service named XYZ of type ABC cannot be found"
Member
Author
There was a problem hiding this comment.
I'm logging an error in case of service not found, shall we throw error 🤔
Collaborator
There was a problem hiding this comment.
mmh logging + ignoring the entity might be good enough!
pmbrull
approved these changes
Jun 2, 2022
Collaborator
|
don't care about the sonar error here |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes :
Amundsen Connector Fix for 0.10.1
Type of change :
Checklist:
Reviewers
@open-metadata/ingestion