Docs: 2 MB issue Fix for External, Tests, Tests UI#203
Docs: 2 MB issue Fix for External, Tests, Tests UI#203RounakDhillon wants to merge 3 commits intomainfrom
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR restructures multiple documentation pages across v1.11.x, v1.12.x, and v1.13.x-SNAPSHOT to address the “2 MB issue” by splitting large sections (External ingestion examples, Column Tests UI, and Column-level Test Definitions) into dedicated pages and updating navigation links.
Changes:
- Added new standalone docs pages for Column Tests (UI), Column-level test definitions (DQ as Code), and External ingestion workflow examples.
- Replaced large embedded sections in overview pages with
<Info>callouts linking to the new pages. - Updated
docs.jsonnavigation to group and include the newly added pages.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| v1.13.x-SNAPSHOT/how-to-guides/data-quality-observability/quality/tests-ui/column-tests.mdx | New dedicated page for column-level UI test configuration. |
| v1.13.x-SNAPSHOT/how-to-guides/data-quality-observability/quality/tests-ui.mdx | Removes embedded column tests content; adds link to new page; sidebar title update. |
| v1.13.x-SNAPSHOT/how-to-guides/data-quality-observability/quality/data-quality-as-code/test-definitions/column-tests.mdx | New dedicated reference page for column-level SDK test definitions. |
| v1.13.x-SNAPSHOT/how-to-guides/data-quality-observability/quality/data-quality-as-code/test-definitions.mdx | Removes embedded column-level definitions; adds link to new page. |
| v1.13.x-SNAPSHOT/deployment/ingestion/external/examples.mdx | New dedicated page containing external workflow code examples. |
| v1.13.x-SNAPSHOT/deployment/ingestion/external.mdx | Replaces embedded examples with a link to the new examples page. |
| v1.12.x/how-to-guides/data-quality-observability/quality/tests-ui/column-tests.mdx | New dedicated page for column-level UI test configuration. |
| v1.12.x/how-to-guides/data-quality-observability/quality/tests-ui.mdx | Removes embedded column tests content; adds link to new page; sidebar title update. |
| v1.12.x/how-to-guides/data-quality-observability/quality/data-quality-as-code/test-definitions/column-tests.mdx | New dedicated reference page for column-level SDK test definitions. |
| v1.12.x/how-to-guides/data-quality-observability/quality/data-quality-as-code/test-definitions.mdx | Removes embedded column-level definitions; adds link to new page. |
| v1.12.x/deployment/ingestion/external/examples.mdx | New dedicated page containing external workflow code examples. |
| v1.12.x/deployment/ingestion/external.mdx | Replaces embedded examples with a link to the new examples page. |
| v1.11.x/how-to-guides/data-quality-observability/quality/tests-ui/column-tests.mdx | New dedicated page for column-level UI test configuration. |
| v1.11.x/how-to-guides/data-quality-observability/quality/tests-ui.mdx | Removes embedded column tests content; adds link to new page; sidebar title update. |
| v1.11.x/how-to-guides/data-quality-observability/quality/data-quality-as-code/test-definitions/column-tests.mdx | New dedicated reference page for column-level SDK test definitions. |
| v1.11.x/how-to-guides/data-quality-observability/quality/data-quality-as-code/test-definitions.mdx | Removes embedded column-level definitions; adds link to new page. |
| v1.11.x/deployment/ingestion/external/examples.mdx | New dedicated page containing external workflow code examples. |
| v1.11.x/deployment/ingestion/external.mdx | Replaces embedded examples with a link to the new examples page. |
| docs.json | Updates sidebar/nav structure to include and group the new pages across versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| def run(): | ||
| workflow = MetadataWorkflow.create(CONFIG) |
There was a problem hiding this comment.
The code examples reference workflow classes (e.g., MetadataWorkflow) that are not imported in the snippet, and CONFIG is a YAML string but is passed directly to .create(...). Update the examples to (1) import the workflow classes used and (2) parse the YAML string into a Python dict (e.g., via yaml.safe_load) before calling .create(...), so the examples are executable as-is.
| | Condition | Status | | ||
| |------------------------------|--------| | ||
| | All values are unique | ✅ | | ||
| | Any duplicate value found | ❌ | |
There was a problem hiding this comment.
These Markdown tables start each row with ||, which typically renders an unintended empty first column (or breaks table formatting depending on the renderer). Replace the leading || with a single | on each row to ensure consistent table rendering.
| ### Column Values to Be Between | ||
| Validates numeric values of a column are within a given range. |
There was a problem hiding this comment.
This section describes validating numeric values, but the 'When to Use' and the behavior table describe string length validation (which is also documented later as 'Column Values Lengths to Be Between'). Align the description + behavior with numeric range validation, or rename/rewrite the section so it is unambiguously about length (and avoid duplicating the later length test).
| - Username length, field input length validation | ||
|
|
||
| #### Behavior | ||
|
|
||
| | Condition | Status | | ||
| |---------------------------------------------|--------| | ||
| | Length within `[min, max]` | ✅ | | ||
| | Length < min or > max | ❌ | |
There was a problem hiding this comment.
This section describes validating numeric values, but the 'When to Use' and the behavior table describe string length validation (which is also documented later as 'Column Values Lengths to Be Between'). Align the description + behavior with numeric range validation, or rename/rewrite the section so it is unambiguously about length (and avoid duplicating the later length test).
| - Username length, field input length validation | |
| #### Behavior | |
| | Condition | Status | | |
| |---------------------------------------------|--------| | |
| | Length within `[min, max]` | ✅ | | |
| | Length < min or > max | ❌ | | |
| - Numeric thresholds such as age, salary, price, score, or quantity validation | |
| #### Behavior | |
| | Condition | Status | | |
| |---------------------------------------------|--------| | |
| | Value within `[min, max]` | ✅ | | |
| | Value < min or > max | ❌ | |
| - Username length, field input length validation | ||
|
|
||
| #### Behavior | ||
|
|
||
| | Condition | Status | | ||
| |---------------------------------------------|--------| | ||
| | Length within `[min, max]` | ✅ | | ||
| | Length < min or > max | ❌ | |
There was a problem hiding this comment.
This section describes validating numeric values, but the 'When to Use' and the behavior table describe string length validation (which is also documented later as 'Column Values Lengths to Be Between'). Align the description + behavior with numeric range validation, or rename/rewrite the section so it is unambiguously about length (and avoid duplicating the later length test).
| - Username length, field input length validation | |
| #### Behavior | |
| | Condition | Status | | |
| |---------------------------------------------|--------| | |
| | Length within `[min, max]` | ✅ | | |
| | Length < min or > max | ❌ | | |
| - Validating metrics such as age, price, quantity, or score fall within expected limits | |
| #### Behavior | |
| | Condition | Status | | |
| |--------------------------------------------|--------| | |
| | Value within `[min, max]` | ✅ | | |
| | Value < min or > max | ❌ | |
| ### ColumnValuesToBeAtExpectedLocation | ||
|
|
||
| Validates that a specific value appears at an expected row position. |
There was a problem hiding this comment.
Within this PR, the UI docs describe 'Column Values To Be At Expected Location' as a latitude/longitude geospatial validation, while this SDK reference describes expected row position semantics. Please reconcile these so the meaning of "Expected Location" is consistent across UI and SDK docs (and update parameters/examples accordingly).
| ></video> | ||
|
|
||
| ### Column Values to not Match Regex | ||
| This test allows us to specify values in a column we expect that will not match a certain regex expression. If the test find values matching the `forbiddenRegex` the test will fail. Please note that for certain databases we will fall back to SQL `LIKE` expression. The databases supporting regex pattern as of 0.13.2 are: |
There was a problem hiding this comment.
Grammar fix: change 'If the test find values' to 'If the test finds values'.
| This test allows us to specify values in a column we expect that will not match a certain regex expression. If the test find values matching the `forbiddenRegex` the test will fail. Please note that for certain databases we will fall back to SQL `LIKE` expression. The databases supporting regex pattern as of 0.13.2 are: | |
| This test allows us to specify values in a column we expect that will not match a certain regex expression. If the test finds values matching the `forbiddenRegex` the test will fail. Please note that for certain databases we will fall back to SQL `LIKE` expression. The databases supporting regex pattern as of 0.13.2 are: |
|
@copilot resolve the merge conflicts in this pull request |
# Conflicts: # docs.json Co-authored-by: ayush-shah <40225091+ayush-shah@users.noreply.github.com>
Merge conflicts resolved in commit |
|
No blocking findings from this validation pass. Validation run:
Residual risk: I did not do a full visual preview walkthrough; this validation focused on mergeability, links, changed-file hygiene, and local reference integrity. |
I worked on 2 MB issue Fix for External, Tests, and Tests UI.