feat: update to alternatenamesV2 to consistently ignore historic geonames#22
Closed
terraputix wants to merge 5 commits into
Closed
feat: update to alternatenamesV2 to consistently ignore historic geonames#22terraputix wants to merge 5 commits into
terraputix wants to merge 5 commits into
Conversation
terraputix
force-pushed
the
update-to-alternatenamesV2
branch
from
d7d00d9 to
813b3cd
Compare
terraputix
force-pushed
the
update-to-alternatenamesV2
branch
from
813b3cd to
2bb82d7
Compare
terraputix
commented
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to https://download.geonames.org/export/dump/readme.txt:
alternatenamesV2.txtalso has a consistent formatting which allows us to easily parse the historic names and ignore them when building the database.Closes #19 (also the mentioned Helsinki issue), #20.
With the updated database I also verified that #4 gets resolved.