-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Update video_demo.py #6734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Update video_demo.py #6734
Conversation
1) wait-time is the wrong name of the variable; 2) the cv.waitKey's parameter delay must be the interger intead of the float datatype.
|
. |
| parser.add_argument('--out', type=str, help='Output video file') | ||
| parser.add_argument('--show', action='store_true', help='Show video') | ||
| parser.add_argument( | ||
| '--wait-time', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MMDetection use '-' to separate words in command arguments, like resume-from, wait-time to ease the usages. So the change in line 22 should be omitted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, absolutely, you are right! But, there is a situation that when I see the code "args.resume_from", I don't know what the argument is and then I want to jump to the parser.add_argument(...) for more information about the args.reume_from, so in the vim normal mode, I will key "mm*ggn" to jump to the destination code line. If the using the _ to separate the words, I can easily jump to line of the code parser.add_argument, but I can't do that if using the - to separate words.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see... The original purpose is to ease the typing in the command line, which we think might be more commonly needed. For your case with VIM, you may directly search for 'wait' rather than 'wait_time'?
For now, we also do not wish break the compatibility of arguments actually
c3ff573 to
54cd1a4
Compare
| parser.add_argument( | ||
| '--wait-time', | ||
| type=float, | ||
| '--wait_time', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All args in mmdet use - instead of _. It will be converted automatically when parsing args.
| '--wait_time', | |
| '--wait-time', |
|
Hi @GuangjiHuang!We are grateful for your efforts in helping improve this open-source project during your personal time. |
wait-time is the wrong name of the variable;
the cv.waitKey's parameter delay must be the interger intead of the float datatype.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist