[Feature] Add remove_eol_characters hook#12
Merged
Conversation
Collaborator
|
Please add the hook in https://github.com/open-mmlab/pre-commit-hooks/blob/master/README.md#hooks-available |
4 tasks
added 3 commits
September 13, 2022 18:15
Contributor
Author
|
Tested with the following config in MMEngine - repo: https://github.com/C1rN09/pre-commit-hooks.git
rev: 02421bc
hooks:
- id: check-copyright
args: ["mmengine", "tests"]
- id: remove-improper-eol-in-cn-docsSeems good. |
zhouzaida
reviewed
Sep 13, 2022
zhouzaida
reviewed
Sep 13, 2022
zhouzaida
reviewed
Sep 13, 2022
eed571f to
0f79723
Compare
zhouzaida
reviewed
Sep 13, 2022
zhouzaida
reviewed
Sep 13, 2022
zhouzaida
reviewed
Sep 13, 2022
zhouzaida
reviewed
Sep 13, 2022
zhouzaida
reviewed
Sep 13, 2022
zhouzaida
reviewed
Sep 13, 2022
zhouzaida
approved these changes
Sep 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new script/pre-commit-hook, named
remove-improper-eol-in-cn-docs.The script aims at resolving extra whitespaces in Chinese docs, which is a long-standing HTML issue as discussed here.
To solve the issue, this script finds and removes end_of_line characters which split natural Chinese paragraphs. For example,
will be changed to
However, the following cases stay unchanged: