This repository was archived by the owner on Sep 30, 2022. It is now read-only.
Merge pull request #1436 from rhc54/topic/names #1016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the process name is positive when using direct launch (cherry picked from commit open-mpi/ompi@7b84207)
|
Test PASSed. |
Member
|
@rhc54 Is this critical for v2.0.0? If so, please mark it with the "blocker" label. |
Contributor
|
👍 |
Member
|
@rhc54 is this a blocker for 2.0.0? |
Contributor
|
@hppritcha @jsquyres My understanding is that it is a blocker. |
Author
|
I can see it either way. It is visible only to someone who direct-launches against an RM that supports PMIx, and none of those will be available until this summer. Given that this release should still be alive by then, it probably is worth bringing it over before release. After all, it is a one-line change 😄 |
hppritcha
added a commit
that referenced
this pull request
Mar 14, 2016
Merge pull request #1436 from rhc54/topic/names
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the process name is positive when using direct launch
(cherry picked from commit open-mpi/ompi@7b84207)