This repository was archived by the owner on Sep 30, 2022. It is now read-only.
osc/sm: Fix a bus error on MPI_WIN_{POST,START}. #1023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bus error occurs in sm OSC under the following conditions. - sparc64 or any other architectures which need strict alignment. - `MPI_WIN_POST` or `MPI_WIN_START` is called for a window created by sm OSC. - The communicator size is odd and greater than 3. The lines 283-285 in current `ompi/mca/osc/sm/osc_sm_component.c` has the following code. ```c module->global_state = (ompi_osc_sm_global_state_t *) (module->segment_base); module->node_states = (ompi_osc_sm_node_state_t *) (module->global_state + 1); module->posts[0] = (uint64_t *) (module->node_states + comm_size); ``` The size of `ompi_osc_sm_node_state_t` is multiples of 4 but not multiples of 8. So if `comm_size` is odd, `module->posts[0]` does not aligned to 8. This causes a bus error when accessing `module->posts[i][j]`. This patch fixes the alignment of `module->posts[0]` by setting `module->posts[0]` first. (cherry picked from open-mpi/ompi@ad26899) Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
Member
Author
|
:bot:assign: @kawashima-fj |
|
Test FAILed. |
Member
|
@miked-mellanox could you check the ucx/oshmem problems we seem to be hitting now? |
Member
|
disabled VG for ucx for now. |
Member
|
bot:retest |
|
Test PASSed. |
Member
|
👍 |
hppritcha
added a commit
that referenced
this pull request
Mar 17, 2016
osc/sm: Fix a bus error on MPI_WIN_{POST,START}.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bus error occurs in sm OSC under the following conditions.
MPI_WIN_POSTorMPI_WIN_STARTis called for a window createdby sm OSC.
The lines 283-285 in current
ompi/mca/osc/sm/osc_sm_component.chasthe following code.
The size of
ompi_osc_sm_node_state_tis multiples of 4 but notmultiples of 8. So if
comm_sizeis odd,module->posts[0]doesnot aligned to 8. This causes a bus error when accessing
module->posts[i][j].This patch fixes the alignment of
module->posts[0]by settingmodule->posts[0]first.(cherry picked from open-mpi/ompi@ad26899)
Signed-off-by: Nathan Hjelm hjelmn@lanl.gov