This repository was archived by the owner on Sep 30, 2022. It is now read-only.
pmix: Increment the reference count in PMIx_Init #1049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reference counting was broken which led PMIx_Finalize to release resources early. This fixes the "use after free" scenarios that I encountered. (based on commit openpmix/openpmix@abfaa4c)
Member
Author
|
:bot:assign: @jsquyres |
Member
Author
|
Here is the pmix PR - openpmix/openpmix#63 |
Member
Author
|
This issue crops up only if PMIx_Init/Finalize is called multiple times. So I'm ok, if this needs to be deferred to v2.0.1. However the fix is small enough, and impacts us, that it might be good to have in v2.0.0. |
|
Test PASSed. |
Member
|
@rhc54 is probably the right person to review this. |
|
👍 |
Member
|
@hppritcha Good to go. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reference counting was broken which led PMIx_Finalize
to release resources early. This fixes the "use after free" scenarios
that I encountered.
(based on commit openpmix/openpmix@abfaa4c)