This repository was archived by the owner on Sep 30, 2022. It is now read-only.
opal_check_libfabric: correctly check for user intent #1052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user asked for libfabric and we can't build for it, abort. Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit open-mpi/ompi@ccdc10d)
|
Test FAILed. |
Member
Author
|
@Di0gen We're told by @jladd-mlnx that you're now the new Jenkins master. Can you look and see what the segv was in the Mellanox Jenkins failure on this PR? It looks like an unrelated segv. Thanks! |
Member
|
👍 |
Member
|
bot:retest |
|
Test PASSed. |
Member
Author
|
@hppritcha and I discussed yesterday; approved. |
|
Test FAILed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user asked for libfabric and we can't build for it, abort.
Signed-off-by: Jeff Squyres jsquyres@cisco.com
(cherry picked from commit open-mpi/ompi@ccdc10d)
@rhc54 or @hppritcha please review