This repository was archived by the owner on Sep 30, 2022. It is now read-only.
Topic/v2.x/oob usock fixes #1058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so usock_peer_create_socket know it must re-create the socket /* assuming it is ever supposed to occur */ also fix a typo (peer->sd >= 0) in usock_peer_create_socket (cherry picked from commit open-mpi/ompi@1707341)
(cherry picked from commit open-mpi/ompi@d757fbb)
|
Test FAILed. |
Member
|
@rhc54 how critical is this? can it be deferred to 2.0.1? |
Contributor
Author
|
:bot:assign: @rhx54 @hppritcha currently, the |
|
OMPIBot error: Label "critical" does not exist. |
Contributor
Author
|
:bot🏷️blocker |
|
Test PASSed. |
|
@hppritcha It's a pretty simple bug fix, really, and probably should go into 2.0 👍 |
Member
|
okay I'm going to go ahead and merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.