This repository was archived by the owner on Sep 30, 2022. It is now read-only.
Somehow, the logic for finalize got lost, so restore it here. #1098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
|
👍 Thanks Ralph for the quick fix. |
….fence_nb is available, then call it and cycle opal_progress until complete. If pmix.fence_nb is not available, then do an MPI_Barrier and call pmix.fence. Needs to go over to 2.x (cherry picked from commit open-mpi/ompi@7373111) ompi_mpi_finalize: add/update comments This is a follow-on to open-mpi/ompi@7373111: add some comments explaining why the code is the way it is. Also update a previous comment. Also, call the back-end barrier directly; do not invoke MPI_Barrier() (we don't invoke the MPI API from anywhere in OMPI -- except ROMIO, because that's an external package -- so that we don't accidentally trip PMPI-based tools). Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit open-mpi/ompi@8ab88f2)
|
Test FAILed. |
|
The Mellanox failure is unrelated to this PR - has something to do with a missing asm file? |
|
Test PASSed. |
|
well this commit causes aprun launched jobs to hang in |
|
Is it hanging in the MPI_Barrier? Or in the pmix.fence? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If pmix.fence_nb is available, then call it and cycle opal_progress until complete. If pmix.fence_nb is not available, then do an MPI_Barrier and call pmix.fence.
Needs to go over to 2.x
(cherry picked from commit open-mpi/ompi@7373111)