This repository was archived by the owner on Sep 30, 2022. It is now read-only.
coll/hcoll: bugfix: initialize req_type field #1196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If left uninitialized then segfault is possible in MPI_Waitall in
the case the field by chance equals OMPI_REQUEST_GEN.
(cherry picked from commit 5ff6372)
|
Test PASSed. |
|
@hppritcha This is a hot fix that needs to go into 2.0.0, please. |
|
@jladd-mlnx Is this related to the open-mpi/ompi#1422 issues, perchance? I.e., is hcoll used behind the scenes in oshmem_hello? |
|
@jsquyres It is not related. |
|
@jsquyres this is a bug fix that I think is okay to go in to 2.0.0 while we wait for other fixes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 5ff6372)
bot:label:bug
bot:milestone:v2.0.0
bot:label:reviewed
🍒 -picked from open-mpi/ompi@5ff6372886e952b
Patch developed by @vspetrov and signed off on by me.