This repository was archived by the owner on Sep 30, 2022. It is now read-only.
Do not set a binding policy when we are overloading the default #1198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
Member
|
👍 |
…1.10, we allow oversubscription by default for non-managed allocations, and we silently do-not-bind if the user has not requested a binding policy and we are overloaded. However, we do enforce oversubscription limits if we are in managed allocations OR the user specified the #slots for a node (either in hostfile or via -host). So be sure to check that for all cases.
Author
|
@abouteiller Please take another look - I believe this now gets all to be consistent |
|
Test PASSed. |
Member
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 1.10, we allow oversubscription by default for non-managed allocations, and we silently do-not-bind if the user has not requested a binding policy and we are overloaded.
Fixes open-mpi/ompi#1709
@abouteiller Please give this a whirl