This repository was archived by the owner on Sep 30, 2022. It is now read-only.
Fix the basic barrier. #1213
Merged
Fix the basic barrier. #1213
+0
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The log basic barrier was completely broken. The rank 0 gets the hibit set to 0, so it always returned an error. (cherry picked from commit open-mpi/ompi@9376b03)
|
Test PASSed. |
|
Hmm... okay, looks like 1cf197d hit some other code as well. Shouldn't these also be fixed? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log basic barrier was completely broken. The rank 0 gets the
hibit set to 0, so it always returned an error.
(cherry picked from commit open-mpi/ompi@9376b03)
Fixed by @bosilca, reviewed by @jsquyres
@hppritcha This made the coll basic barrier totally busted. Needs to be in v2.0.0. It's good to go.