Skip to content
This repository was archived by the owner on Sep 30, 2022. It is now read-only.

Conversation

@hjelmn
Copy link
Member

@hjelmn hjelmn commented Jun 17, 2016

This commit fixes a compile error on 32-bit platforms. The
low-priority call counter was always using 64-bit atomics which will
not work if 64-bit atomic math is not available. Updated to use 32-bit
instead.

Signed-off-by: Nathan Hjelm hjelmn@lanl.gov

(cherry picked from commit dbd8369)

Signed-off-by: Nathan Hjelm hjelmn@lanl.gov

This commit fixes a compile error on 32-bit platforms. The
low-priority call counter was always using 64-bit atomics which will
not work if 64-bit atomic math is not available. Updated to use 32-bit
instead.

Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>

(cherry picked from commit dbd8369)

Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
@hjelmn
Copy link
Member Author

hjelmn commented Jun 17, 2016

:bot🏷️bug
:bot:milestone:v2.0.1
:bot:assign: @PHHargrove

This restores ppc32 support. @hppritcha Marking this for 2.0.1 as it is not very high priority.

@mellanox-github
Copy link

Test FAILed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1783/ for details.

@PHHargrove
Copy link
Member

@hppritcha

I disagree with the assignment of the v2.0.1 milestone.

The problem is NOT just ppc32, but all 32-bit targets with the exception of x86 (which has 64-bit atomics).
Without this patch ppc32, mips32 and arm are all failing because they lack 64-bit atomics.

@hppritcha hppritcha modified the milestones: v2.0.0, v2.0.1 Jun 17, 2016
@hppritcha
Copy link
Member

bot:retest

@hppritcha
Copy link
Member

@jsquyres I'm okay with putting this in to 2.0.0

@mellanox-github
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1785/ for details.

@jsquyres
Copy link
Member

Good analysis, @PHHargrove; thanks.

@jsquyres
Copy link
Member

I wasn't clear: @hjelmn @PHHargrove When this is reviewed, we'll put it in 2.0.0. Please review ASAP.

@PHHargrove
Copy link
Member

PHHargrove commented Jun 17, 2016

@jsquyres
I should be able to get "-m32" on ppc64 (the first system to show the problem) tested in under an hour.
The mips32 and arm systems may take several hours (thank goodness I have h/w and not just QEMU as in the past).
However, I am confident I can review by the end of today (AOE).

@PHHargrove
Copy link
Member

I should be able to get "-m32" on ppc64 (the first system to show the problem) tested in under an hour.

OK, that case passed and so I am fairly confident the rest will, too.

However, I will defer the thumbs-up until I have at least one result each from arm and mips32.

@PHHargrove
Copy link
Member

👍
I now have at least one success each from ppc32, mips32 and arm (which had all failed with the 2.0.0rc3 tarball).

@jsquyres jsquyres merged commit 18cbc09 into open-mpi:v2.x Jun 18, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants