-
Notifications
You must be signed in to change notification settings - Fork 68
opal/progress: use 32-bit atomics for call counter #1232
Conversation
This commit fixes a compile error on 32-bit platforms. The low-priority call counter was always using 64-bit atomics which will not work if 64-bit atomic math is not available. Updated to use 32-bit instead. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov> (cherry picked from commit dbd8369) Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
|
:bot🏷️bug This restores ppc32 support. @hppritcha Marking this for 2.0.1 as it is not very high priority. |
|
Test FAILed. |
|
I disagree with the assignment of the v2.0.1 milestone. The problem is NOT just ppc32, but all 32-bit targets with the exception of x86 (which has 64-bit atomics). |
|
bot:retest |
|
@jsquyres I'm okay with putting this in to 2.0.0 |
|
Test PASSed. |
|
Good analysis, @PHHargrove; thanks. |
|
I wasn't clear: @hjelmn @PHHargrove When this is reviewed, we'll put it in 2.0.0. Please review ASAP. |
|
@jsquyres |
OK, that case passed and so I am fairly confident the rest will, too. However, I will defer the thumbs-up until I have at least one result each from arm and mips32. |
|
👍 |
This commit fixes a compile error on 32-bit platforms. The
low-priority call counter was always using 64-bit atomics which will
not work if 64-bit atomic math is not available. Updated to use 32-bit
instead.
Signed-off-by: Nathan Hjelm hjelmn@lanl.gov
(cherry picked from commit dbd8369)
Signed-off-by: Nathan Hjelm hjelmn@lanl.gov