This repository was archived by the owner on Sep 30, 2022. It is now read-only.
usock: remove left-over CR code #1234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquyres
force-pushed
the
pr/v2.0.0/compiler-warnings-fixes
branch
from
aa56120 to
67dfd16
Compare
Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
jsquyres
force-pushed
the
pr/v2.0.0/compiler-warnings-fixes
branch
from
67dfd16 to
0fd1907
Compare
|
Test PASSed. |
|
@jsquyres this was intentionally left in because I thought Cisco wanted to keep us nic code as similar as possible across all branches. But it's Cisco code and if you'd like it removed that's fine with me. |
|
@hppritcha The code in question is in oob/usock, not btl/usnic. |
|
Yeah, that needs to come out - it snuck in when we restored the usock component 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jeff Squyres jsquyres@cisco.com
@hppritcha This code was accidentally left over in The Great CR Purge of 2016. Do you have strong feelings about whether this fix goes into v2.0.0 or v2.0.1? It causes a compile warning because
OPAL_ENABLE_FT_CRis no longer defined.