This repository was archived by the owner on Sep 30, 2022. It is now read-only.
bml r2: remove use of undefined macro #1236
Merged
+1
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OPAL_ENABLE_THREAD_MULTI is not defined any more; we *always* need that write barrier. Fixes ompi/issues#1796. Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
|
Test PASSed. |
|
I'm fine with this change. |
|
@hjelmn Reviewed in open-mpi/ompi#1796 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPAL_ENABLE_THREAD_MULTI is not defined any more; we always need that write barrier.
Fixes open-mpi/ompi#1796.
Signed-off-by: Jeff Squyres jsquyres@cisco.com
@hjelmn please review
@hppritcha I think this write barrier is important for v2.0.0.