This repository was archived by the owner on Sep 30, 2022. It is now read-only.
Makefile.am: only check for common symbols on dev builds #1259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only run "find_common_syms" in the install-exec-hook when a .git directory is present in the source dir. Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit open-mpi/ompi@62c45e4)
|
👍 |
|
release managers decided this is very low risk and doesn't warrant a new rc. |
|
Test PASSed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only run "find_common_syms" in the install-exec-hook when a .git
directory is present in the source dir.
Signed-off-by: Jeff Squyres jsquyres@cisco.com
(cherry picked from commit open-mpi/ompi@62c45e4)
Thanks to Tetsuya Mishima for raising the issue.
@hppritcha I think that this is worth it for v2.0.0 -- even at this late stage -- due to the very reason @ggouaillardet and Tetsuya raise in https://www.open-mpi.org/community/lists/devel/2016/07/19159.php: we don't want users to be alarmed by this false positive. Additionally, the risk is very low in this small commit. Thoughts?