Skip to content
This repository was archived by the owner on Sep 30, 2022. It is now read-only.

Conversation

@ggouaillardet
Copy link
Contributor

This is a work around to avoit what looks like a CMake bug

Thanks Paul Kapinos for the report

Fixes open-mpi/ompi#1868

(cherry picked from commit open-mpi/ompi@2a98f9f)

This is a work around to avoit what looks like a CMake bug

Thanks Paul Kapinos for the report

Fixes open-mpi/ompi#1868

(cherry picked from commit open-mpi/ompi@2a98f9f)
@lanl-ompi
Copy link
Contributor

Test FAILed.

@ggouaillardet
Copy link
Contributor Author

:bot:assign: @jsquyres
:bot:milestone:v2.0.1
:bot🏷️enhancement

@mellanox-github
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1862/ for details.


uninstall-local:
rm -f $(DESTDIR)/$(includedir)/mpp/shmem.h \
$(DESTDIR)/$(includedir)/mpp/shmem.fh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you need to remove the mpp directory as well?

@ggouaillardet
Copy link
Contributor Author

@jsquyres that is an option
before writing the commit, i ran make uninstall and here is the content of the install dir

./share
./share/openmpi
./share/openmpi/amca-param-sets
./share/man
./share/man/man7
./share/man/man3
./share/man/man1
./etc
./lib
./lib/openmpi
./lib/pkgconfig
./bin
./include
./include/openmpi
./include/openmpi/ompi
./include/openmpi/ompi/mpiext
./include/openmpi/ompi/mpiext/affinity
./include/openmpi/ompi/mpiext/affinity/c
./include/openmpi/ompi/mpiext/cuda
./include/openmpi/ompi/mpiext/cuda/c
./include/openshmem
./include/openshmem/oshmem
./include/mpp

bottom line, directories are not removed, so for the sake of consistency, i chose not to remove the include/mp directory.
that is not a strong opinion, so if you feel this should be removed, i'll update the PR

@ggouaillardet
Copy link
Contributor Author

:bot:nolabel:pushed-back

@jsquyres
Copy link
Member

@ggouaillardet You're right; I guess I thought that make uninstall removed directories too, but I guess it doesn't. 👍

@jsquyres
Copy link
Member

bot:retest

@mellanox-github
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1893/ for details.

@mellanox-github
Copy link

Test FAILed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1930/ for details.

@jsquyres jsquyres merged commit 4c985f9 into open-mpi:v2.x Jul 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants