This repository was archived by the owner on Sep 30, 2022. It is now read-only.
v2.x: oob/usock: fix handling of orte_process_name_t * #1357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orte_process_name_t is aligned on 32 bits, so it cannot simply be casted into an int64_t. use memcpy() instead Thanks Paul Hargrove for the report (back-ported from commit open-mpi/ompi@0b8c582)
ggouaillardet
changed the title
|
Test PASSed. |
|
:bot🏷️bug @hppritcha this was reported by Paul Hargrove with v2.0.1rc2 |
|
👍 |
|
Per discussion with @rhc54, this is really a blocker. The patch is straightforward, the risk is low, and this does fix a common error that occurred in real testing. Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
orte_process_name_t is aligned on 32 bits, so it cannot simply be casted
into an int64_t. use memcpy() instead
Thanks Paul Hargrove for the report
(back-ported from commit open-mpi/ompi@0b8c582)