This repository was archived by the owner on Sep 30, 2022. It is now read-only.
btl/openib: queue pending fragments once only when running out of credit #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes open-mpi/ompi#640 (cherry picked from commit open-mpi/ompi@9f171de)
|
:bot:assign: @hjelmn |
|
:bot🏷️bug |
|
OMPIBot error: Milestone "v2.0.0" does not exist. |
|
:bot🏷️bug |
|
OMPIBot error: Label "bug" is already set on issue 369. |
|
bot:retest |
|
Jeff/Howard decided today (7/6/15) to let this cook in master for a week. If no problems seen, will merge at that time. |
|
time to merge |
hppritcha
added a commit
that referenced
this pull request
Jul 14, 2015
…redit_fix btl/openib: queue pending fragments once only when running out of credit
nrgraham23
pushed a commit
to nrgraham23/ompi-release
that referenced
this pull request
Aug 20, 2015
This pull request adds two Buffer references to the Request class. Whenever a request object is created that has associated buffers, the buffers should be added to these references so the java garbage collector does not dispose of the buffers prematurely. This is a more robust expansion on the idea first proposed by @ggouaillardet, and further discussed in open-mpi#369. Fixes open-mpi#369 Manual cherry-pick from d363b5d Signed-off-by: Nathaniel Graham <ngraham@lanl.gov>
Merged
nrgraham23
pushed a commit
to nrgraham23/ompi-release
that referenced
this pull request
Aug 24, 2015
This pull request adds an arraylist of type Buffer to the Request class. Whenever a request object is created that has associated buffers, the buffers should be added to this array list so the java garbage collector does not dispose of the buffers prematurely. This is a more robust expansion on the idea first proposed by @ggouaillardet Fixes open-mpi#369 Signed-off-by: Nathaniel Graham <ngraham@lanl.gov>
tkordenbrock
pushed a commit
to tkordenbrock/ompi-release
that referenced
this pull request
Aug 28, 2015
This pull request adds two Buffer references to the Request class. Whenever a request object is created that has associated buffers, the buffers should be added to these references so the java garbage collector does not dispose of the buffers prematurely. This is a more robust expansion on the idea first proposed by @ggouaillardet, and further discussed in open-mpi#369. Fixes open-mpi#369 Manual cherry-pick from d363b5d Signed-off-by: Nathaniel Graham <ngraham@lanl.gov>
tkordenbrock
pushed a commit
to tkordenbrock/ompi-release
that referenced
this pull request
Aug 28, 2015
This pull request adds an arraylist of type Buffer to the Request class. Whenever a request object is created that has associated buffers, the buffers should be added to this array list so the java garbage collector does not dispose of the buffers prematurely. This is a more robust expansion on the idea first proposed by @ggouaillardet Fixes open-mpi#369 Signed-off-by: Nathaniel Graham <ngraham@lanl.gov>
alinask
pushed a commit
to alinask/ompi-release
that referenced
this pull request
Dec 10, 2015
This pull request adds an arraylist of type Buffer to the Request class. Whenever a request object is created that has associated buffers, the buffers should be added to this array list so the java garbage collector does not dispose of the buffers prematurely. This is a more robust expansion on the idea first proposed by @ggouaillardet Fixes open-mpi#369 Signed-off-by: Nathaniel Graham <ngraham@lanl.gov>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes open-mpi/ompi#640
(cherry picked from commit open-mpi/ompi@9f171de)