This repository was archived by the owner on Sep 30, 2022. It is now read-only.
hint processing should not open files #511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move opening of files from hint processing and into open routines. This is MPICH commit 92f1c69f0de8 and 22a77dceda11 see https://trac.mpich.org/projects/mpich/ticket/2261 Ref: open-mpi/ompi#158 Signed-off-by: Pavan Balaji <balaji@anl.gov> Conflicts: ompi/mca/io/romio314/romio/adio/ad_lustre/ad_lustre_open.c
Member
Author
|
@edgargabriel looks like somethings wrong with ad_lustre_open.c, it doesn't compile with lustre enabled for romio |
fix the romio patch from ANL Signed-off-by: Howard Pritchard <howardp@lanl.gov>
Member
Author
|
pushed the same fix Edgar did for master - I think. an errant bracket from Rob's patch. |
Member
|
yes, sorry for the delay, you will need 8561f5f to compile correctly. |
Member
|
looks good as far as I can see. Some of the files in the ad_lustre subdirectory still show differences in whitespaces compared to master, but content wise it looks now identical. |
jsquyres
added a commit
that referenced
this pull request
Aug 17, 2015
hint processing should not open files
alex-mikheev
pushed a commit
to alex-mikheev/ompi-release
that referenced
this pull request
Nov 11, 2015
osc/pt2pt: fix synchronization bugs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move opening of files from hint processing and into open routines.
This is MPICH commit 92f1c69f0de8 and 22a77dceda11
see https://trac.mpich.org/projects/mpich/ticket/2261
Ref: open-mpi/ompi#158
Signed-off-by: Pavan Balaji balaji@anl.gov
Conflicts:
ompi/mca/io/romio314/romio/adio/ad_lustre/ad_lustre_open.c
@edgargabriel
cherry-pick of open-mpi/ompi@6e9cbe39