Pr/commits of week 33 #513
Conversation
…e prototype for the static function to avoid a warning message.
…to the fs_lustre.h file.
…in our array group-communication operations.
- make the internal structure follow the Open MPI naming convention - provide a single flag/macro which controls the compilation/utilization of this feature, to avoid that somebody using this has to modify every single fcoll component. A configure option could be added later if desired.
- minor code restructering in io/ompio required for that.
There was a problem hiding this comment.
may opal_output instead of printf?
|
except for minor printf/opal_output this looks good to me. |
|
I can fix the printf vs. opal_output thing, will add it to this pr a bit later today. Thanks! Also wandering whether I should add the coverty fixes that Jeff sent me over the weekend to the same pr, or should I file a new one? |
|
As long as the coverity fix goes in as a distinct commit (cherry-picked) 2015-08-17 8:01 GMT-06:00 Edgar Gabriel notifications@github.com:
|
|
being nice to mlnx bot retest please |
|
@hppritcha I added the commit for cleanup of printf vs. opal_output ( for all three sharedfp components in v2.x). I would suggest that the coverity fix goes in a separate pr. The fix is not entirely trivial and it might be towards the end of the week before I get to it. |
|
👍 |
|
OMPIBot error: Label "reviewed" is already set on issue 513. |
opal: fix multiple bugs in MCA and opal
4 participants
it looks like I forgot to file a pr for the split collective shared file pointer tests, so I included it in this pr.