Skip to content
This repository was archived by the owner on Sep 30, 2022. It is now read-only.

fortran: do not build the f08 bindings if PMPI is not built #633

Closed
wants to merge 1 commit into from
Closed

fortran: do not build the f08 bindings if PMPI is not built #633

wants to merge 1 commit into from

Conversation

@ggouaillardet
Copy link
Contributor

@ggouaillardet ggouaillardet commented Oct 5, 2015

(cherry picked from commit open-mpi/ompi@2d1a8fa)

@ggouaillardet ggouaillardet force-pushed the topic/v1.10/f08_vs_pmpi branch from c14e169 to d97c871 Compare October 5, 2015 02:02
@mellanox-github
Copy link

mellanox-github commented Oct 5, 2015

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-v1.8-pr/794/ for details.

@mellanox-github
Copy link

mellanox-github commented Oct 5, 2015

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-v1.8-pr/795/ for details.

@ggouaillardet
Copy link
Contributor Author

ggouaillardet commented Oct 5, 2015

:bot:assign: @jsquyres
:bot🏷️bug
:bot:milestone:v1.10.1

@ompiteam-bot ompiteam-bot added this to the v1.10.1 milestone Oct 5, 2015
@ggouaillardet
Copy link
Contributor Author

ggouaillardet commented Oct 5, 2015

the --enable-mpi-profile option will soon be removed from master and v2.x so i am not planning to PR this for the v2.x branch

@jsquyres
Copy link
Member

jsquyres commented Oct 6, 2015

See comments on open-mpi/ompi@2d1a8fa

@ggouaillardet ggouaillardet force-pushed the topic/v1.10/f08_vs_pmpi branch 2 times, most recently from b54ea46 to e13c230 Compare October 7, 2015 00:44
@lanl-ompi
Copy link
Contributor

lanl-ompi commented Oct 7, 2015

Test FAILed.

@ggouaillardet
Copy link
Contributor Author

ggouaillardet commented Oct 7, 2015

:bot:retest

@ggouaillardet ggouaillardet force-pushed the topic/v1.10/f08_vs_pmpi branch from e13c230 to 35bca4d Compare October 7, 2015 01:16
@mellanox-github
Copy link

mellanox-github commented Oct 7, 2015

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-v1.8-pr/814/ for details.

@mellanox-github
Copy link

mellanox-github commented Oct 7, 2015

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-v1.8-pr/815/ for details.

@mellanox-github
Copy link

mellanox-github commented Oct 7, 2015

Test FAILed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-v1.8-pr/817/ for details.

@mellanox-github
Copy link

mellanox-github commented Oct 7, 2015

Test FAILed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-v1.8-pr/816/ for details.

@ggouaillardet
Copy link
Contributor Author

ggouaillardet commented Oct 7, 2015

:bot:retest

@mellanox-github
Copy link

mellanox-github commented Oct 7, 2015

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-v1.8-pr/818/ for details.

@ggouaillardet ggouaillardet force-pushed the topic/v1.10/f08_vs_pmpi branch from 35bca4d to cc69b42 Compare October 7, 2015 08:13
@ggouaillardet
Copy link
Contributor Author

ggouaillardet commented Oct 7, 2015

:bot:nolabel:pushed-back

@mellanox-github
Copy link

mellanox-github commented Oct 7, 2015

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-v1.8-pr/823/ for details.

@jsquyres
Copy link
Member

jsquyres commented Oct 7, 2015

Ah, you updated this per open-mpi/ompi#990. Same minor nit that I noted there: don't use "" around $MPI_MPI_PROFILING.

@jsquyres
Copy link
Member

jsquyres commented Oct 7, 2015

@ggouaillardet and I chatted on open-mpi/ompi@2d1a8fa -- we agreed to fix this in v2.0.0 and not worry about it for v1.10.x.

@jsquyres jsquyres closed this Oct 7, 2015
@ggouaillardet
Copy link
Contributor Author

ggouaillardet commented Oct 8, 2015

@jsquyres there is a misunderstanding ...
currently, v1.10 configure does not abort if the user requests let's say usempif08 binding but this bindings cannot be built. this is solved in master and v2.x, and i am fine not to backport this to the v1.10 series.
this PR is about not building usempif08 if PMPI is not built, and though this is quite a minor issue, it is also a minor fix and i think it should make it for 1.10.1

alinask pushed a commit to alinask/ompi-release that referenced this pull request Dec 10, 2015
@bosilca
Merge pull request open-mpi#633 from bosilca/topic/enable_atomics
984b35b 
Enable by default the _sync version of atomic operations on OS X.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@jsquyres jsquyres

Labels

bug

Projects

None yet

Milestone

v1.10.1

Development

Successfully merging this pull request may close these issues.

5 participants

@ggouaillardet @mellanox-github @jsquyres @lanl-ompi @ompiteam-bot