configury: do not build usempif08 is PMPI is not built #990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggouaillardet
force-pushed
the
topic/f08_vs_pmpi
branch
from
88bf9b4 to
10f7d6f
Compare
Contributor
|
Test FAILed. |
2 similar comments
Contributor
|
Test FAILed. |
Contributor
|
Test FAILed. |
ggouaillardet
force-pushed
the
topic/f08_vs_pmpi
branch
from
10f7d6f to
e875f97
Compare
ggouaillardet
referenced
this pull request
Oct 7, 2015
config/ompi_setup_mpi_fortran.m4
Outdated
Member
There was a problem hiding this comment.
Since you're using -eq here, then $WANT_MPI_PROFILING must be a number. So don't use "" around $WANT_MPI_PROFILING (which will promote the value to a string).
Contributor
Author
There was a problem hiding this comment.
will do.
that being said, I am a bit surprised...
if test is not a builtin functions, "" should be just a sh thing to handle the case when the variable is not defined.
but anyway, this is inconsistent with the rest of the code so I will fix it
this is a revamp of commit open-mpi/ompi@2d1a8fa Thanks Jeff for the review !
ggouaillardet
force-pushed
the
topic/f08_vs_pmpi
branch
from
e875f97 to
d7e6daf
Compare
Member
|
👍 |
jsquyres
added a commit
that referenced
this pull request
Oct 12, 2015
configury: do not build usempif08 is PMPI is not built
jsquyres
pushed a commit
to jsquyres/ompi
that referenced
this pull request
Aug 23, 2016
…hetero btl/openib: fix heterogeneous support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a revamp of commit 2d1a8fa
Thanks Jeff for the review !